Skip to content

Commit

Permalink
v2v: -o glance: Fix metadata for disk type and NIC (RHBZ#1161575).
Browse files Browse the repository at this point in the history
The labels 'hw_disk_bus' and 'hw_vif_model' were swapped.  This
happened to work for virtio guests.  For non-virtio guests you ended
up with absurdities like requiring an rtl8139 driver for the disk.

Thanks: Junquin Zhou
  • Loading branch information
rwmjones committed Nov 7, 2014
1 parent 75b37b7 commit 7407c0a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions v2v/output_glance.ml
Expand Up @@ -74,11 +74,11 @@ object
(* Set the properties (ie. metadata). *)
let min_ram = source.s_memory /^ 1024L /^ 1024L in
let properties = [
"hw_vif_model",
"hw_disk_bus",
(match guestcaps.gcaps_block_bus with
| Virtio_blk -> "virtio"
| IDE -> "ide");
"hw_disk_bus",
"hw_vif_model",
(match guestcaps.gcaps_net_bus with
| Virtio_net -> "virtio"
| E1000 -> "e1000"
Expand Down

0 comments on commit 7407c0a

Please sign in to comment.