Implementation file for Uart and example code. #204

Jeremy-Chau · 2018-10-05T03:13:02Z

Implementation file for Uart and example code.

Jeremy-Chau · 2018-10-15T01:22:44Z

Khalil,
I can't figure out how to properly implement the Pin Pairs lookup table. I guess I don't quite understand how to use a look up table of function calls. I thought I could use the table in the same manner as I did before creating the table but the build errors state otherwise. For reference, below is how I was able to setup the pins before creating the table.

    tx_pin_ = Pin(kTxChannel[mode_], kTxPortPin[mode_]);
    rx_pin_ = Pin(kRxChannel[mode_], kRxPortPin[mode_]);

kammce · 2018-10-15T06:04:30Z

Khalil,
I can't figure out how to properly implement the Pin Pairs lookup table. I guess I don't quite understand how to use a look up table of function calls. I thought I could use the table in the same manner as I did before creating the table but the build errors state otherwise. For reference, below is how I was able to setup the pins before creating the table.
    tx_pin_ = Pin(kTxChannel[mode_], kTxPortPin[mode_]);
    rx_pin_ = Pin(kRxChannel[mode_], kRxPortPin[mode_]);

With the way you are doing this, you can omit the tx_pin_ and the rx_pin_, even though this should work. Simply use a map of Uart Pins and assign their pointers to the tx_ and rx_ pointers.

- Moved color range from lowest red = 50 and highest necessary green to 90. - Precision has been moved to 1 decimal place. This should result in deltas less than .1% not be considered as coverage failures.

codecov-io · 2018-10-25T01:45:46Z

Codecov Report

❗ No coverage uploaded for pull request base (master@96e59c3). Click here to learn what that means.
The diff coverage is 79.5%.

@@           Coverage Diff            @@
##             master    #204   +/-   ##
========================================
  Coverage          ?   84.9%           
========================================
  Files             ?      43           
  Lines             ?    2025           
  Branches          ?       0           
========================================
  Hits              ?    1719           
  Misses            ?     306           
  Partials          ?       0

Impacted Files	Coverage Δ
firmware/library/L1_Drivers/uart_test.cpp	`100% <100%> (ø)`
firmware/library/L1_Drivers/pin.hpp	`100% <100%> (ø)`
firmware/library/L1_Drivers/uart.hpp	`69.3% <69.1%> (ø)`
firmware/library/L1_Drivers/gpio.hpp	`90% <85.8%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e59c3...7313ce4. Read the comment docs.

coveralls · 2018-10-25T02:01:46Z

Coverage decreased (-2.6%) to 80.913% when pulling 7313ce4 on Jeremy-Chau:UART into 96e59c3 on kammce:master.

kammce · 2018-10-25T03:50:54Z

Even though coveralls says you decreased coverage by 2.6%, I will still merge you code in because it drops the binary size considerable (~3kB I think).

Jeremy-Chau · 2018-10-25T04:26:54Z

Were you able to properly verify that the code works on the board?

kammce · 2018-10-25T04:32:42Z

Haven't been able to get the driver working yet. Will test more tomorrow.

kammce · 2018-10-26T14:29:46Z

Figured out the issue. It mostly had to do with the fact that the UART0 pins were not correct. UART0 must be P0.2 and P0.3 since we need that for serial communication with host machine. Which means that the pin function bits were also off. After changing those and a few other things I got it to work.

See master's version of "Jeremy-Chau-UART" and make those changes to your repo. Ignore the changes to Hyperload though. I will make those changes after this is merged in.

Jeremy-Chau · 2018-10-26T22:46:30Z

I believe I got all the changes in this updated commit. Please let me know if I missed any.

kammce

Do not go make the pull requests idential. Do not delete uart0.hpp and uart2.hpp. Just make the changes you need to, to uart.hpp.

kammce · 2018-10-26T23:11:55Z

firmware/library/L1_Drivers/uart.hpp

+    uint8_t receiver         = 0;
+    uint64_t timeout_time    = Milliseconds() + timeout;
+    uint64_t current_time    = Milliseconds();
+    uint8_t timeout_receiver = uart_base_reg[channel_]->LSR & (1 << 0);


It isn't polling if you only check once.

1. Consolidated multiple look up tables for the pairs of pins and added enumerations to simplify the code. 2. Has the timeout feature implemented. 3. Changed pin to pin_ and port to port_ in pin.hpp and gpio.hpp files 4. Working on improving code coverage. The only line that doesn't work deals with checking the DLL.

Jeremy-Chau · 2018-10-28T03:06:09Z

I should be finished with the code. Just can't figure out why the DLL register is empty from the testing file.

Jeremy-Chau force-pushed the UART branch from 4a83ef9 to cef6fd0 Compare October 14, 2018 18:36

Jeremy-Chau force-pushed the UART branch 2 times, most recently from fdf1aca to 46f1167 Compare October 23, 2018 02:32

Making Codecov indicator more leniant

69e93dd

- Moved color range from lowest red = 50 and highest necessary green to 90. - Precision has been moved to 1 decimal place. This should result in deltas less than .1% not be considered as coverage failures.

Jeremy-Chau force-pushed the UART branch 9 times, most recently from b5505d0 to 21ae6bc Compare October 24, 2018 01:27

Merge branch 'master' of https://github.com/kammce/SJSU-Dev2

8ba05f9

Jeremy-Chau force-pushed the UART branch from 21ae6bc to 0f3af9c Compare October 25, 2018 01:41

libhal deleted a comment from codecov-io Oct 25, 2018

Jeremy-Chau force-pushed the UART branch from 0f3af9c to f78803e Compare October 25, 2018 01:45

Merge branch 'master' of https://github.com/kammce/SJSU-Dev2

48f611a

Jeremy-Chau force-pushed the UART branch from f78803e to 1ba4e22 Compare October 26, 2018 22:45

kammce requested changes Oct 26, 2018

View reviewed changes

Jeremy-Chau force-pushed the UART branch from 1ba4e22 to 5a0b450 Compare October 27, 2018 03:02

Jeremy-Chau force-pushed the UART branch from 5a0b450 to 7313ce4 Compare October 27, 2018 23:14

kammce merged commit 482cad9 into libhal:master Oct 28, 2018

kammce mentioned this pull request Oct 28, 2018

UART Controller #1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation file for Uart and example code. #204

Implementation file for Uart and example code. #204

Jeremy-Chau commented Oct 5, 2018

Jeremy-Chau commented Oct 15, 2018

kammce commented Oct 15, 2018

codecov-io commented Oct 25, 2018 •

edited

Loading

coveralls commented Oct 25, 2018 •

edited

Loading

kammce commented Oct 25, 2018

Jeremy-Chau commented Oct 25, 2018

kammce commented Oct 25, 2018

kammce commented Oct 26, 2018

Jeremy-Chau commented Oct 26, 2018

kammce left a comment

kammce Oct 26, 2018

Jeremy-Chau commented Oct 28, 2018

Implementation file for Uart and example code. #204

Implementation file for Uart and example code. #204

Conversation

Jeremy-Chau commented Oct 5, 2018

Jeremy-Chau commented Oct 15, 2018

kammce commented Oct 15, 2018

codecov-io commented Oct 25, 2018 • edited Loading

Codecov Report

coveralls commented Oct 25, 2018 • edited Loading

kammce commented Oct 25, 2018

Jeremy-Chau commented Oct 25, 2018

kammce commented Oct 25, 2018

kammce commented Oct 26, 2018

Jeremy-Chau commented Oct 26, 2018

kammce left a comment

Choose a reason for hiding this comment

kammce Oct 26, 2018

Choose a reason for hiding this comment

Jeremy-Chau commented Oct 28, 2018

codecov-io commented Oct 25, 2018 •

edited

Loading

coveralls commented Oct 25, 2018 •

edited

Loading