Fix wheel building for 3.12
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
commented
Feb 9, 2024
|
|
||
| - name: Install cibuildwheel | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install cibuildwheel==2.12.0 | ||
| python -m pip install cibuildwheel |
There was a problem hiding this comment.
If you want to pin, I've tested with 2.16.5. But I'm not sure if it is worth it, really.
There was a problem hiding this comment.
Ah, interesting. So the mistake was pinning in the first place.
There was a problem hiding this comment.
I think it might have also been the 3.7 python version for the pip install, but not sure
paddyroddy
commented
Feb 9, 2024
Comment on lines
-100
to
+113
| name: artifact | ||
| pattern: artifact-* | ||
| merge-multiple: true |
There was a problem hiding this comment.
paddyroddy
commented
Feb 9, 2024
| with: | ||
| name: artifact-sdist |
There was a problem hiding this comment.
paddyroddy
commented
Feb 9, 2024
| with: | ||
| path: | | ||
| name: artifact-wheel-${{ matrix.cpversion }}-${{ matrix.os.cibw-arch }} |
There was a problem hiding this comment.
Merged
|
Will be there a release to support |
|
Hopefully this will succeed and I'll push a 2.5.1 release to pip https://github.com/libigl/libigl-python-bindings/actions/runs/8392415109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221. Have tested in CI on my own fork and appears to work. Not sure exactly what was required, but I've made the CI generally more readable, and updated versions of actions.