-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"zfsize < zs.size" error for libzip-1.1.2 #43
Comments
Also seeing this on Ubuntu 16.04 with libzip 1.0.1. #38 was closed saying to use libzip >= 0.10, I assume the 1.0 libzip change is what broke this:
The following patch will get it building but I then get the error
|
Hi, I got same error with libzip 1.1.2 on OSX 10.12 Beta (16A201w).
|
The problem is on line 54: #ifndef ZIP_CODEC_ENCODE |
#53 seems to fix this issue for me using xcode8 GM |
…sues Modified the define check to look for LIBZIP_VERSION as opposed to ZIP_CODEC_ENCODE. libzip 0.10 introduced LIBZIP_VERSION (which is also used by all later versions) and also introduced the defines that the guard handles. ZIP_CODEC_ENCODE is no longer used by later libzip versions (e.g. 1.12) which was causing compilation errors. Also, the config.ac has a check that libzip is >= 0.10 so this is mostly a moot point.
The problem is lines 56-58 of src/ideviceinstaller.c. As mentioned on line 55, they are for old versions of libzip -- versions prior to 0.10. The file uses the presence of ZIP_CODEC_ENCODE to distinguish libzip version 0.10 from earlier versions. The problem, though, is that ZIP_CODEC_ENCODE was moved to the (non-public) header file zipint.h sometime after version 0.11.2c. So, if a newer version of libzip is being used, lines 56-58 are used, and cause compilation errors. |
The reason for this is that these lines are only useful for very old versions of libzip, but those versions are now disallowed by the configure script. This fixes issues libimobiledevice#43, libimobiledevice#50, libimobiledevice#66, and (probably) libimobiledevice#55.
The problem is the |
Yes, but line 20 of configure.ac already requires libzip version 0.10 or higher: PKG_CHECK_MODULES(libzip, libzip >= 0.10) |
Fixed with #85 |
I got an error like in issue #38 when use libzip-1.1.2.
But for libzip-0.11.2 there are no errors.
The text was updated successfully, but these errors were encountered: