Fix compile error on macOS (and other OSes) #43 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pachoo
added a commit
to pachoo/ideviceinstaller
that referenced
this pull request
Dec 2, 2016
…sues Modified the define check to look for LIBZIP_VERSION as opposed to ZIP_CODEC_ENCODE. libzip 0.10 introduced LIBZIP_VERSION (which is also used by all later versions) and also introduced the defines that the guard handles. ZIP_CODEC_ENCODE is no longer used by later libzip versions (e.g. 1.12) which was causing compilation errors. Also, the config.ac has a check that libzip is >= 0.10 so this is mostly a moot point.
|
IMNHSO it would be better to delete lines 54-60 (in src/ideviceinstaller.c). See my (second) comment on issue #43 |
|
Fixed with #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.