This repository has been archived by the owner on Dec 21, 2018. It is now read-only.
Fix channels opening when services are added/restarted. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 7, 2017
compose.go
Outdated
| // Check if containers exist in the desirated state for the given services | ||
| func (p *Project) existContainers(stateFiltered project.State, services ...string) (bool, error) { | ||
| existingContainers := false | ||
| var err error = nil |
There was a problem hiding this comment.
should drop = nil from declaration of var err; it is the zero value
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
====================================
Coverage 0% 0%
====================================
Files 1 1
Lines 125 148 +23
====================================
- Misses 125 148 +23 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services management (#6 and #7 ) feature show that closing channels after all actions don't allow starting multiple services or restarting project.
This PR allows to close channels only if all project services are deleted and allows to recreate environment if necessary.