Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make begemph and endemph more intelligent #1002

Closed
bertfrees opened this issue Oct 12, 2020 · 1 comment
Closed

Make begemph and endemph more intelligent #1002

bertfrees opened this issue Oct 12, 2020 · 1 comment
Assignees
@bertfrees
Labels
enhancement An enhancement in the functionality (not a bug fix or a table improvement)
Milestone
3.16

Comments

@bertfrees
Copy link
Member

bertfrees commented Oct 12, 2020 •
edited
Loading

begemph and endemph should behave a bit more like the phrase indicators when it comes to determining the beginning and end of the emphasized passage. This means by default emphasis on non-letters should be ignored, and if defined, the new noemphchars (#905) should be taken into account. emphmodechars should not be taken into account, this is strictly a word scope thing.
@bertfrees bertfrees added the enhancement An enhancement in the functionality (not a bug fix or a table improvement) label Oct 12, 2020
@bertfrees bertfrees mentioned this issue Oct 12, 2020
Closed
@bertfrees bertfrees added this to the 3.16 milestone Oct 16, 2020
@bertfrees bertfrees self-assigned this Oct 16, 2020
bertfrees added a commit that referenced this issue Oct 16, 2020
@bertfrees
Add two emphasis tests
92e1013 
- behavior of begemph/endemph w.r.t. spaces (related to
  #1002)
- order of opening and closing indicators (related to
  #922)
bertfrees added a commit that referenced this issue Oct 16, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
e68f7ad 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
bertfrees added a commit that referenced this issue Oct 16, 2020
@bertfrees
Add two emphasis tests
e41e9b0 
- behavior of begemph/endemph w.r.t. spaces (related to
  #1002)
- order of opening and closing indicators (related to
  #922)
bertfrees added a commit that referenced this issue Oct 16, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
dbc4b8b 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
@bertfrees bertfrees mentioned this issue Oct 16, 2020
Merged
bertfrees added a commit that referenced this issue Oct 19, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
92fb88a 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
bertfrees added a commit that referenced this issue Nov 20, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
b9a5bfa 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
bertfrees added a commit that referenced this issue Nov 20, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
63ded76 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
bertfrees added a commit that referenced this issue Nov 24, 2020
@bertfrees
Add two emphasis tests
4b77b72 
- behavior of begemph/endemph w.r.t. spaces (related to
  #1002)
- order of opening and closing indicators (related to
  #922)
bertfrees added a commit that referenced this issue Nov 24, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
f389964 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
@bertfrees
Copy link
Member Author

Fixed by #1006. This new paragraph in the documentation (6039326) summarizes how the behavior of begemph/endemph changed:

Characters that you have defined in your table as "not emphasizable" in braille (see noemphchars) are not indicated as such by Liblouis. This means that if an emphasized phrase begins or ends with such characters, they will not be within the part enclosed by the two indicators. Also, if multiple emphasized parts are separated by unemphasizable characters only, it will be indicated as if it was a single emphasized phrase, with one start indicator and one end indicator.

bertfrees added a commit that referenced this issue Nov 30, 2020
@bertfrees
Add two emphasis tests
dd230ca 
- behavior of begemph/endemph w.r.t. spaces (related to
  #1002)
- order of opening and closing indicators (related to
  #922)
bertfrees added a commit that referenced this issue Nov 30, 2020
@bertfrees
Remove some of the special handling of begemph/endemph
4d92719 
This further harmonizes the behavior and further simplifies the code.

The new noemphchars can be used to achieve the old behavior.

Related to #1002.
@egli egli closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertfrees bertfrees

Labels
enhancement An enhancement in the functionality (not a bug fix or a table improvement)
Projects
None yet
Milestone
3.16
Development

No branches or pull requests
2 participants
@egli @bertfrees