Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in resolveTable #69

Closed
wants to merge 1 commit into from
Closed

Bugfix in resolveTable #69

wants to merge 1 commit into from

Conversation

bertfrees
Copy link
Member

No description provided.

@bertfrees
Copy the result of resolveTable
dfbe3a0 
because it may be garbage collected if it's a Java string (tableResolver
may be a Java function)

and also because we free it which is illegal if it's a Java string (bug
introduced by commits 63dd676 to a53250d).
@bertfrees bertfrees added this to the 2.7.0 milestone Mar 10, 2015
@bertfrees
Copy link
Member Author

Is this O.K. to merge?

@bertfrees bertfrees mentioned this pull request Apr 9, 2015
Closed
3 tasks
@egli
Copy link
Member

egli commented Apr 9, 2015

kinda sucks. There is probably a better solution but I don't have time for it now. Can this wait till W17?

@egli
Copy link
Member

egli commented May 22, 2015

I don't care enough so let's merge

@bertfrees
Copy link
Member Author

Rebased and merged.

@bertfrees bertfrees closed this May 22, 2015
@egli
Copy link
Member

egli commented May 22, 2015

@bertfrees can we mention this in the NEWS file. Thanks

@bertfrees bertfrees deleted the bfrees_bugfix_tableresolver branch May 22, 2015 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bertfrees bertfrees

Labels
None yet
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bertfrees @egli