New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Norwegian tables #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That reminds me, there are some commits from NLB that we better merge too. |
@bertfrees do you have those commits? |
The purpose of this update is mainly to fix some problems caused by an update in April 2015, that led to misbehavior when used with devices that don't understand unicode bbraille. Some characters are moved to get higher priority to output from liblouis. In addition, I've added/fixed braille representation for some capital accented letters that previously was wrong. These chars are added to the test file no_harness.yaml as well. Still there are one issue that I hope someone else can look into: the begcomp/endcomp construct. I've added a test case, with status xfail, in the file no_backward.yaml, to demonstrate the problem. The problem is not introduced with this update.
bertfrees
force-pushed
the
tables/norwegian
branch
2 times, most recently
from
February 26, 2019 18:38
f81fed5
to
1ff83a7
Compare
bertfrees
force-pushed
the
tables/norwegian
branch
from
February 26, 2019 18:40
1ff83a7
to
1e9302d
Compare
Rebased onto master and added some commits. @egli If you're OK with it we can merge. |
bertfrees
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this update is mainly to fix some problems caused by an update
in April 2015, that led to misbehavior when used with devices that don't
understand unicode bbraille. Some characters are moved to get higher
priority to output from liblouis.
In addition, I've added/fixed braille representation for some capital
accented letters that previously was wrong. These chars are added to the test file
no_harness.yaml as well.
Still there are one issue that I hope someone else can look into: the
begcomp/endcomp construct. I've added a test case, with status xfail, in the
file no_backward.yaml, to demonstrate the problem. The problem is not
introduced with this update.