Various changes to Norwegian #695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because Liblouis is not meant to be build directly from within liblouis-nar.
Notably for languages that have a table for contracted braille as well. Also make UEB the default for "en". In commit fb78caa I claimed that I had made en-ueb-g1 discoverable, but that's not true. I only made en-us-g1 discoverable. That is now fixed.
Updated braille table names based on comments from @larsbjorndal. Also moved everything except license text into the metadata block and marked up all copyright texts and changelog contributors as metadata. Declared no-no-comp8.ctb as a libloiuis computer braille table. The no-no-8dot.utb table that was marked as computer braille is now changed to literary braille, as it extends the computer braille table with additional characters.
both through emphasis classes ("sub" and "super") or through subscript
and superscript characters.
bertfrees
added
tables
This fixes build against automake 1.16.
- added figure dash as dot 36. fixes nlbdev/pipeline#210 - added ligature oe as norse letter dot 346. - change undefined character from dot 26 to dot 0 (space). fixes nlbdev/pipeline#113 - enable testing of sami, norse and icelandic characters that actually work. - removed xfail from two tests that now work - fixed test with "š" character - use ⠡ (16) instead of ⠷ (12356) for "á" (a with acute). i.e. use norwegian instead of sami representation. closes nlbdev/pipeline#159
|
I dropped the commit "Handle URLs and e-mail addresses in Java instead of liblouis" and merged with master here: https://github.com/liblouis/liblouis/compare/nlb |
|
@egli Review if you want. I want to merge this before I do Lars' PR. |
bertfrees
removed
the
needs fixup
egli
reviewed
Feb 26, 2019
|
You should have looked at https://github.com/liblouis/liblouis/compare/nlb. Most of your comments are not relevant anymore I'm afraid. |
|
Yes that looks much better and addresses most of my comments. I just looked at https://github.com/liblouis/liblouis/pull/695/files which is the list of changed files in this PR. |
|
Ah, maybe that is the list of changes modulo the conflicts that have to be resolved |
|
It's the same branch with some commits removed, and then merged with the latest master. |
bertfrees
added a commit
that referenced
this pull request
Feb 26, 2019
as per Christian's request: #695 (comment)
bertfrees
added a commit
that referenced
this pull request
Feb 26, 2019
as per Christian's request: #695 (comment)
bertfrees
added a commit
that referenced
this pull request
Feb 26, 2019
|
Merged in 8dbdd34 |
|
Not deleting branch because NLB still uses it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... done by NLB in the past year and a half.