Fix tcllib not found #184
Open
Fix tcllib not found #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase your work against current master ? We're using github-action now, rather than travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is my second attempt to fix an issue whereby the tcl library was not being found by the configure script (with the –enable-tcl option) on systems where the library was stored in an unusual or unexpected location.
My first pull request worked in some scenarios, but not others due to the large number of different locations that are used to store libraries by Debian’s multiarch specification.
I have also revamped the Travis build test and updated it to include all configurations, not just PHP. The Travis builds failed with my previous pull request because it was configured to use a decommissioned distro, and not because of any errors with my changes. I have corrected this.
There have also been some minor updates to the autoconf and automake scripts to address some depreciation warnings that were being generated when the above commands were run.