Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct swftocxx code generation #54

Closed
wants to merge 1 commit into from
Closed

correct swftocxx code generation #54

wants to merge 1 commit into from

Conversation

lieff
Copy link
Contributor

@lieff lieff commented Nov 4, 2016

#36 related fixes.

strk
strk requested changes Jan 30, 2017
View reviewed changes
Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the "Files changed" tab only shows functional changes, it's less work to review.

If you can, adding a testsuite for the disassembler would be a great way to secure such fixes.

util/outputscript.c
}
if( sblock->PlaceFlagHasColorTransform ) {
sprintf(cname, "i%d", sblock->Depth);
outputSWF_CXFORMWITHALPHA(&sblock->ColorTransform, cname);
}
if( sblock->PlaceFlagHasRatio ) {
printf(COMMSTART " PlaceFlagHasRatio " COMMEND "\n");
printf(COMMSTART " PlaceFlagHasRatio " COMMEND "\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mix style and functional changes

@strk strk mentioned this pull request Mar 21, 2017
Closed
@strk
Copy link
Member

strk commented Apr 7, 2017

well never mind, pushed as 33737c1

@strk strk closed this Apr 7, 2017
@lieff
Copy link
Contributor Author

lieff commented May 2, 2017

Ouch, sorry, I'm accidentally miss notifications..

@cxlzff cxlzff mentioned this pull request Jun 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strk strk strk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lieff @strk