Fix various overflows in OpCode and readBytes #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applying this patch will also fix CVE-2017-11731 (#84) 👍 |
|
Would you mind including "Fixes #xx" "Fixes #yy" etc. in the commit log so the relevant tickets are automatically closed on merge ? Also please add an entry in the NEWS file so there's nothing else for me to do other than merging :) Thanks! |
* OpCode: Add a check to avoid reading the stack when n < 1
In this case, print a debug warning and return error code -998
* readBytes: When size < 0, set it to zero (don't read anything)
This commit fixes CVE-2017-11728 (Fixes libming#82), CVE-2017-11729 (Fixes libming#79),
CVE-2017-11730 (Fixes libming#81) and CVE-2017-11731 (Fixes libming#84).
Commit updated :) |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpCode: Add a check to avoid reading the stack when n < 1.
In this case, print a debug warning and return error code -998
readBytes: When size < 0, set it to zero (don't read anything) and print a warning
This commit fixes CVE-2017-117{28,29,30} (#82, #81 and #79).