Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heap buffer overflow in decompileCALLFUNCTION #90

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Fix heap buffer overflow in decompileCALLFUNCTION #90

merged 1 commit into from
Oct 11, 2017

Conversation

hlef
Copy link
Contributor

@hlef hlef commented Oct 6, 2017

Make sure that n > 1 before checking for the previous action in the actions array, otherwise an overflow may occur.

This PR fixes CVE-2017-11734 (fixes #83).

@hlef
Copy link
Contributor Author

hlef commented Oct 6, 2017

Hum, something is wrong: first condition should be n >= 1 and not n > 1.

@hlef
Fix heap buffer overflow in decompileCALLFUNCTION
1f59763 
Make sure that n > 0 before checking for the previous action in the
actions array, otherwise an overflow may occur.

This commit fixes CVE-2017-11734 (fixes libming#83).
@hlef
Copy link
Contributor Author

hlef commented Oct 6, 2017

Pull request updated.

@hlef hlef mentioned this pull request Oct 10, 2017
Closed
@strk strk self-assigned this Oct 11, 2017
@strk strk merged commit a3b394a into libming:master Oct 11, 2017
@cxlzff cxlzff mentioned this pull request Jun 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@strk strk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

heap buffer overflow in decompileCALLFUNCTION
2 participants
@hlef @strk