Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile.include still has lots of duplication #33

Closed
karlp opened this issue Dec 16, 2013 · 2 comments
Closed

makefile.include still has lots of duplication #33

karlp opened this issue Dec 16, 2013 · 2 comments
Labels
bug

Comments

@karlp
Copy link
Member

karlp commented Dec 16, 2013

There's virtually identical copies of makefile.include for many families.

The only real differences are:

  • the name of the library
  • ARCH_FLAGS (for hard/soft float etc)
  • the -DSTM32_XX (and similar)

We should maybe just have a makefile.rules and then even simpler per platform makefiles?

Downsides are that it's a little harder to just copy it into your own project?
@BuFran
Copy link
Member

BuFran commented Jan 1, 2014

Adressed in #37

@BuFran
Copy link
Member

BuFran commented Jan 15, 2014

Solved in push 1b98ef8

@BuFran BuFran closed this as completed Jan 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlp @BuFran