-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic Makefile.rules #37
Conversation
Looks generally good at first glance. Might need to update some docs a little to say how to use liboencm3 in your own project? |
Currently I need to solve the flashing problem first, and make some tests with it on the real hardware. Maybe the flashing rules will be better stripped out from the Makefile.rules to the Makefile.flashoocd, Makefile.flashbmp ... it is idea |
endif | ||
endif | ||
ARCH_FLAGS = -mthumb -mcpu=cortex-m3 -msoft-float -mfix-cortex-m3-ldrd | ||
#-march=armv7 ??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just drop this -march line, the -mcpu supersedes it and is more precise anyway.
Reworked by: Frantisek Burian <BuFran@seznam.cz>
…3 library placement
…eorganization of *FLAGS Using: http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#Warning-Options http://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html#Preprocessor-Options http://gcc.gnu.org/onlinedocs/gcc/Link-Options.html#Link-Options http://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html#ARM-Options To CFLAGS are added only -ffunction-sections -fdata-sections, so this should not break the build.
I think this has enough good stuff in it now to merge it, anything else can probably just be addressed later |
That will make my testing easier. I tried to add the pull branch as a
Still working through each to insure all are in alignment. --Chuck On Tue, Jan 14, 2014 at 1:45 PM, Karl Palsson notifications@github.comwrote:
|
@ChuckM 3) AHA ! that can be the point of your malfunction ! I do not recommend the installation of locm3 into toolchain. As README says that WILL broke the build and WILL generate hard faults. The locm in the toolchain cannot use any -L and -I flags, and the build system provides it always ! (currently detection is skipped). I recommend to specify OPENCM3_DIR to root of your built library. This commit wil be my first push to master via rebase, hopefully good, so i place a time for that tomorrow. Thanks for review, @karlp |
You are correct Frantisek! After restructuring my makes to not use the Given the embedded nature of the -examples plus -loc3 as a sub-repository On Tue, Jan 14, 2014 at 3:04 PM, Frantisek Burian
|
Merged via rebase at 1b98ef8 |
Remove duplication of Makefile.includes and move the base into Makefile.rules, generic for all stm32 examples.
Some testing to the flashers is needed
ISSUES:
generic flasher code in current version doesn't work (needs to add some specific parameters)