f4-discovery usb_cdcacm cleanup #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up of f4-discovery usb_cdcacm sample. - Named endpoints - Named result codes - Data buffer made static instead of allocated on stack - Used sizeof-based values where possible
| static uint8_t usbd_control_buffer[128]; | ||
|
|
||
| /* Data I/O buffer */ | ||
| static char data_buf[64]; |
There was a problem hiding this comment.
Right, no reason to use char here.
|
The general problem with something like this is that it results in the examples being different. They really need to be more common, not diverging with this cdcacm example being completely different from the others. |
|
@karlp I cannot really update all examples because I do not own every possible supported board/arch. Or rather, I can - why not, I just cannot verify the changes in that case. Examples are already different enough. Example: not sure what this line does here and I'm pretty sure it's wrong: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some samples are slightly rough around the corners. I think they can be made a little bit more self-descriptive. Here's clean up of f4-discovery usb_cdcacm sample. Things modified: