[stm32] start implementing timer_get_frequency #286
Conversation
untested and only valid for F1 and STM32F405xx/07xx and STM32F415xx/17xx does not handle/check TIMPRE in RCC_CFGR found in F42xxx and F43xxx
| { | ||
| return RCC_CFGR & RCC_CFGR_PPRE1; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't see any real motivation to have this as api funtions visible to users, it's something you would just use internally. If a user needs this information, they (should) have it from when they set up the clock themselves in the first place
There was a problem hiding this comment.
Well, the only reason was to get this independent of the STM family, so the rest of the get_timer_frequency doesn't have to be implemented for each family...
|
I like this new api, but it needs more look to the other peripherals, such as usarts, spis and need to design more globally stable api. Well, I agree with karlp in that the reading of PPRE1/PPRE2 should be internal to the clock computation routine, or it should be shifted to give more generic numbers 0...N |
|
So you would rather have the full timer_get_frequency function implemented for each family? |
Get the timer clock frequency in order to more conveniently calculate the prescaler.
Ran out of time, so in case this sounds useful and someone wants to test it and/or extend it for more chips, here we go....