Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stm32] safe gpio toggle #337

Closed
wants to merge 3 commits into from
Closed

[stm32] safe gpio toggle #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b49886a
[stm32] gpio_toggle: ensure correct state of non-toggled pins.
Jul 16, 2014
1de1126
[stm32f3] gpio_toggle: ensure correct state of non-toggled pins.
Jul 16, 2014
5ed3cc2
Merge branch 'master' into stm32-safe-gpio-toggle
Sep 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/stm32/common/gpio_common_all.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ uint16_t gpio_get(uint32_t gpioport, uint16_t gpios)
/*---------------------------------------------------------------------------*/
/** @brief Toggle a Group of Pins

Toggle one or more pins of the given GPIO port. This is not an atomic operation.
Toggle one or more pins of the given GPIO port. The toggling is not atomic, but
the non-toggled pins are not affected.

@param[in] gpioport Unsigned int32. Port identifier @ref gpio_port_id
@param[in] gpios Unsigned int16. Pin identifiers @ref gpio_pin_id
Expand All @@ -86,7 +87,8 @@ Toggle one or more pins of the given GPIO port. This is not an atomic operation.
*/
void gpio_toggle(uint32_t gpioport, uint16_t gpios)
{
GPIO_ODR(gpioport) ^= gpios;
uint32_t port = GPIO_ODR(gpioport);
GPIO_BSRR(gpioport) = ((port & gpios) << 16) | (~port & gpios);
}

/*---------------------------------------------------------------------------*/
Expand Down