Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usb: control complete callback has no return value #498

Closed
wants to merge 1 commit into from
Closed

usb: control complete callback has no return value #498

wants to merge 1 commit into from

Conversation

karlp
Copy link
Member

@karlp karlp commented Jul 29, 2015

It's never used, so let's make it void to avoid any confusion.

@karlp
usb: control complete callback has no return value
ea75451 
It's never used, so let's make it void to avoid any confusion.
@kuldeepdhaka kuldeepdhaka mentioned this pull request Sep 7, 2015
Closed
@fenugrec fenugrec mentioned this pull request Oct 13, 2015
Closed
@daniel-thompson
Copy link
Contributor

I've just closed #544 in favour of this one. Note that the review comments in #544 included a comment from the author of commit 4b89272 confirming the original switch from void to int was unintentional. This should be good to pull.

@karlp
Copy link
Member Author

karlp commented Oct 14, 2015

you're right, not really any reason to sit on this any longer. merged in 7814d06

@karlp karlp closed this Oct 14, 2015
@karlp karlp deleted the pulls/usb-complete-void branch October 14, 2015 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karlp @daniel-thompson