usb: Use enumerated return codes and usbd_control_complete_callback type #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,17 +218,17 @@ static int usbdfu_control_request(usbd_device *usbd_dev, struct usb_setup_data * | |||
| (*buf)[4] = usbdfu_state; | |||
| (*buf)[5] = 0; /* iString not used here */ | |||
| *len = 6; | |||
| *complete = usbdfu_getstatus_complete; | |||
| return 1; | |||
| *complete = (usbd_control_complete_callback) usbdfu_getstatus_complete; | |||
There was a problem hiding this comment.
why the cast? what type is missing here?
kuldeepdhaka
force-pushed
the
usb/use-enum-and-cb
branch
from
0341f44
to
ff6e8b4
Compare
fix examples for incomming PR #497.
kuldeepdhaka
force-pushed
the
usb/use-enum-and-cb
branch
from
ff6e8b4
to
5388f38
Compare
|
@karlp removed all unrelated whitespace changes and complete callback casting |
|
I still get warnings from a few examples with this one:
Can you please check that you've got everything here? |
|
libopencm3/libopencm3#498 should be merged in libopencm3 before libopencm3/libopencm3#497. |
|
no energy left to manage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix examples for incomming PR libopencm3#497.