Skip to content

Commit

Permalink
PTX-17968 Skip reference validation for tel secret for operators belo…
Browse files Browse the repository at this point in the history
…w 1.10

Signed-off-by: nikolaypopov <nikolay.popov86@gmail.com>
  • Loading branch information
nikolaypopov committed May 19, 2023
1 parent de0b60b commit 6360d03
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions pkg/util/test/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,13 @@ func validateTelemetrySecret(cluster *corev1.StorageCluster, timeout, interval t
return nil, true, fmt.Errorf("waiting for ownerReference to be set to StorageCluster %s in secret %s", cluster.Name, secret.Name)
}
// validate secret owner should not have owner reference
for _, reference := range secret.OwnerReferences {
if reference.UID == ownerRef.UID {
return nil, true, fmt.Errorf("secret %s should not have ownerReference to StorageCluster %s", secret.Name, cluster.Name)
// Do not validate reference for PX Operators below 1.10, as this was introduced in 1.10+, see PWX-26326 for more info
opVersion, _ := GetPxOperatorVersion()
if opVersion.GreaterThanOrEqual(opVer1_10) {
for _, reference := range secret.OwnerReferences {
if reference.UID == ownerRef.UID {
return nil, true, fmt.Errorf("secret %s should not have ownerReference to StorageCluster %s", secret.Name, cluster.Name)
}
}
}
return nil, false, nil
Expand Down

0 comments on commit 6360d03

Please sign in to comment.