Skip to content

Commit

Permalink
Add test debugging
Browse files Browse the repository at this point in the history
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
  • Loading branch information
Grant Griffiths committed Jul 28, 2023
1 parent c561fd6 commit baf4b36
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/util/test/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -3019,7 +3019,7 @@ func ValidateGrafana(pxImageList map[string]string, cluster *corev1.StorageClust
func ValidateGrafanaDeployment(cluster *corev1.StorageCluster, shouldBeInstalled bool, pxImageList map[string]string) error {
deployment, err := appops.Instance().GetDeployment("px-grafana", cluster.Namespace)
if err != nil {
return err
return fmt.Errorf("failed to get deployment in ns %v: %v", cluster.Namespace, err)
}

if err := appops.Instance().ValidateDeployment(deployment, 2*time.Minute, 10*time.Second); err != nil {
Expand Down
3 changes: 3 additions & 0 deletions test/integration_test/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1280,5 +1280,8 @@ func BasicGrafanaRegression(tc *types.TestCase) func(*testing.T) {
}
cluster = ci_utils.UpdateAndValidateGrafana(cluster, updateParamFunc, ci_utils.PxSpecImages, t)
require.Nil(t, cluster.Spec.Monitoring, "failed to validate Monitoring block, it should be nil here, but it is not: %+v", cluster.Spec.Monitoring)

// Delete and validate StorageCluster deletion
ci_utils.UninstallAndValidateStorageCluster(cluster, t)
}
}

0 comments on commit baf4b36

Please sign in to comment.