PWX-28826: Handle pre-flight check for DMthin #1014

jrivera-px · 2023-04-05T15:55:32Z

Modify operator to execute a pre-flight on each node in the cluster. This pre-flight will actually be executed by oci-monitor and px-runc installed on the host. The pre-flight will determine if DMthin can be enabled on the cluster. We do this by having operator launch a daemonset using the storage config with an extra pre-flight option. This will cause oci-monitor to run in pre-flight mode which executes checks via px-runc on each node. The results of the check are passed to oci-monitor via a json file. They are read in and added to the StorageNode obj and passed to operator. Once the checks are done this pre-flight daemonset is deleted by the operator. The operator processes the checks returned in the StorageNode obj to determine if the existing storage config can be modified to enable DMthin (add: -T dmthin param). If the checks fail then the storage config is not updated and the cluster starts with the original stc.

Which issue(s) this PR fixes (optional)
Closes #
PWX-28826

Special notes for your reviewer:
px-runc side is in this PR: https://github.com/portworx/porx/pull/11018
px-installer side is in this PR: https://github.com/portworx/px-installer/pull/1679

Signed-off-by: Harsh Desai <hadesai@purestorage.com>

Signed-off-by: Jose Rivera <jose@portworx.com>

…WX-28826

* Updating CSV to use 23.3.1 released image * Update for 23.3.1 release * Controller gen vendor Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29389 Add CRD for portworx diags collection Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29409: Ignore zones with no nodes (#1008) In disaggregated mode, there could be zones in which no storage nodes might be present. Such a zone would make the maxSNPZ value to be 0. CHanging the behavior to ignore 0 nodes in a zone for maxSNPZ calculation. Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> --------- Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>

Signed-off-by: Jose Rivera <jose@portworx.com>

…emove 'wait' code. Signed-off-by: Jose Rivera <jose@portworx.com>

Signed-off-by: Jose Rivera <jose@portworx.com>

drivers/storage/portworx/component/securitycontextconstraints.go

drivers/storage/portworx/portworx.go

pkg/controller/storagecluster/storagecluster.go

piyush-nimbalkar · 2023-04-06T21:53:58Z

pkg/preflight/utils.go

@@ -11,8 +11,9 @@ func IsEKS() bool {

 // RequiresCheck returns whether a preflight check is needed based on the platform
 func RequiresCheck() bool {
+	return true


I thought we wanted to enable this only on EKS, right?

No the way Harsh and Prabir thought this should go is that we would always run the pre-flight and we have a check for EKS stuff in IsEKS() condition blocks.

I am assuming we will fix this later and run it only on cloud or if the metadata device is already provided. Correct?

Yeah I opened up https://portworx.atlassian.net/browse/PWX-30418 to make sure.

pkg/controller/storagecluster/storagecluster.go

Signed-off-by: Jose Rivera <jose@portworx.com>

…that don't work since Validate was removed from the controller.validate() func. PWX-30373 to try and fix later. Signed-off-by: Jose Rivera <jose@portworx.com>

… check failure to trigger the needed workflow. Signed-off-by: Jose Rivera <jose@portworx.com>

Signed-off-by: Jose Rivera <jose@portworx.com>

…space. Signed-off-by: Jose Rivera <jose@portworx.com>

…running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com>

codecov · 2023-04-10T23:13:14Z

Codecov Report

Patch coverage: 71.65% and no project coverage change.

Comparison is base (c2a317c) 77.73% compared to head (300aee1) 77.74%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #1014    +/-   ##
========================================
  Coverage   77.73%   77.74%            
========================================
  Files          60       61     +1     
  Lines       16362    16678   +316     
========================================
+ Hits        12719    12966   +247     
- Misses       2772     2817    +45     
- Partials      871      895    +24

Impacted Files	Coverage Δ
...e/portworx/component/securitycontextconstraints.go	`86.55% <ø> (ø)`
pkg/preflight/utils.go	`33.33% <0.00%> (ø)`
pkg/util/util.go	`52.61% <ø> (ø)`
pkg/controller/storagecluster/storagecluster.go	`79.06% <37.50%> (-1.38%)`	⬇️
drivers/storage/portworx/portworx.go	`84.67% <51.35%> (-1.21%)`	⬇️
drivers/storage/portworx/preflight.go	`77.99% <77.99%> (ø)`

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ctionality correctly. Signed-off-by: Jose Rivera <jose@portworx.com>

piyush-nimbalkar · 2023-04-12T18:41:47Z

drivers/storage/portworx/portworx.go

+
+		// Add five minute timeout.  If we do reconcile loop check we will need a different way.
+		cnt++
+		if cnt == 100 { // 3s * 100 = 300s (5 mins)


This may not be enough because the first time we would be pulling the px-enterprise image as well. Should we set it to 10mins?

incremented the time for now and logged https://portworx.atlassian.net/browse/PWX-30419 to fix this.

piyush-nimbalkar · 2023-04-12T18:44:09Z

pkg/preflight/utils.go

@@ -11,8 +11,9 @@ func IsEKS() bool {

 // RequiresCheck returns whether a preflight check is needed based on the platform
 func RequiresCheck() bool {
+	return true


I am assuming we will fix this later and run it only on cloud or if the metadata device is already provided. Correct?

Signed-off-by: Jose Rivera <jose@portworx.com>

… exists. Signed-off-by: Jose Rivera <jose@portworx.com>

Signed-off-by: Jose Rivera <jose@portworx.com>

* PWX-28826 Boilerplace Signed-off-by: Harsh Desai <hadesai@purestorage.com> * more boilerplate Signed-off-by: Harsh Desai <hadesai@purestorage.com> * PWX-28826: Pre-flight check for DMthin. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Add comments and move StorageNode cleanup. Signed-off-by: Jose Rivera <jose@portworx.com> * Passed checks should be Info events. Signed-off-by: Jose Rivera <jose@portworx.com> * Passed checks should be Info events. (#1010) Signed-off-by: Jose Rivera <jose@portworx.com> * Pwx 28826 (#1011) * Pwx 28826 (#1012) * PWX-28826: Update with the latest master changes. (#1013) * Updating CSV to use 23.3.1 released image * Update for 23.3.1 release * Controller gen vendor Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29389 Add CRD for portworx diags collection Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29409: Ignore zones with no nodes (#1008) In disaggregated mode, there could be zones in which no storage nodes might be present. Such a zone would make the maxSNPZ value to be 0. CHanging the behavior to ignore 0 nodes in a zone for maxSNPZ calculation. Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> --------- Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com> * Add PassPreFlight event tag and logging Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Check status of portworx container in pre-flight pod and remove 'wait' code. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Fix unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Fix unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: PR review changes and fix portworx_test.go UTs Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: fix gomack Validate calls. Also comment out the two tests that don't work since Validate was removed from the controller.validate() func. PWX-30373 to try and fix later. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30373: Re-add back in the commented out tests and add K8s version check failure to trigger the needed workflow. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Exit pre-check wait if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Add 5 min timeout to pre-flight status check. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Exit GetPreFlightStatus() with success if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Don't automatically enable dmthin via pre-flight check if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30373: Revert UT and integration test hacks. Need to mock the functionality correctly. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Increase pre-flight daemonset ready wait to 10mins. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: fix 'TestValidate' UT. Don't error if pre-flight daemonset exists. Signed-off-by: Jose Rivera <jose@portworx.com> * Only run preflight if AWS. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Harsh Desai <hadesai@purestorage.com> Signed-off-by: Jose Rivera <jose@portworx.com> Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: Harsh Desai <hadesai@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>

* PWX-29973 Add check result to StorageNode CRD (#992) Signed-off-by: Harsh Desai <hadesai@purestorage.com> * [PWX-25353][PWX-25355] Auto detect eks cloud environment and check cloud permissions * [PWX-27619] Update cloudops vendor for EKS dry run * [PWX-27619] Use dry run for eks cloud permission check * [PWX-27621] Fix cluster status issue after running preflight * [PWX-25354] Set default cloud storage spec on EKS * PWX-27656: auto-ssl support (resync w/ DaemonSet) (#826) Syncs DaemonSet changes done for auto- ssl/tls support: * adding events/update RBAC permission * adding certificatesigningrequests RBAC permissions * adding containerdvardir (/var/lib/containerd) mount Signed-off-by: Zoran Rajic <zrajic@purestorage.com> * [PWX-27588] Add support for EKS cloud storage capacity based configuration * [PWX-27622] Use provided AWS credentials to run permission check on EKS * [PWX-28664] Unset AWS credential env vars after client creation * PWX-29973 Add check result to StorageNode CRD (#992) Signed-off-by: Harsh Desai <hadesai@purestorage.com> * [PWX-27765] StorageCluster status redesign to show more details * PWX-28826: Handle pre-flight check for DMthin (#1014) * PWX-28826 Boilerplace Signed-off-by: Harsh Desai <hadesai@purestorage.com> * more boilerplate Signed-off-by: Harsh Desai <hadesai@purestorage.com> * PWX-28826: Pre-flight check for DMthin. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Add comments and move StorageNode cleanup. Signed-off-by: Jose Rivera <jose@portworx.com> * Passed checks should be Info events. Signed-off-by: Jose Rivera <jose@portworx.com> * Passed checks should be Info events. (#1010) Signed-off-by: Jose Rivera <jose@portworx.com> * Pwx 28826 (#1011) * Pwx 28826 (#1012) * PWX-28826: Update with the latest master changes. (#1013) * Updating CSV to use 23.3.1 released image * Update for 23.3.1 release * Controller gen vendor Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29389 Add CRD for portworx diags collection Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29409: Ignore zones with no nodes (#1008) In disaggregated mode, there could be zones in which no storage nodes might be present. Such a zone would make the maxSNPZ value to be 0. CHanging the behavior to ignore 0 nodes in a zone for maxSNPZ calculation. Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> --------- Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com> * Add PassPreFlight event tag and logging Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Check status of portworx container in pre-flight pod and remove 'wait' code. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Fix unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Fix unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: PR review changes and fix portworx_test.go UTs Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: fix gomack Validate calls. Also comment out the two tests that don't work since Validate was removed from the controller.validate() func. PWX-30373 to try and fix later. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30373: Re-add back in the commented out tests and add K8s version check failure to trigger the needed workflow. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Exit pre-check wait if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Add 5 min timeout to pre-flight status check. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Exit GetPreFlightStatus() with success if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Don't automatically enable dmthin via pre-flight check if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30373: Revert UT and integration test hacks. Need to mock the functionality correctly. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Increase pre-flight daemonset ready wait to 10mins. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: fix 'TestValidate' UT. Don't error if pre-flight daemonset exists. Signed-off-by: Jose Rivera <jose@portworx.com> * Only run preflight if AWS. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Harsh Desai <hadesai@purestorage.com> Signed-off-by: Jose Rivera <jose@portworx.com> Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: Harsh Desai <hadesai@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com> * PWX-30496: if '-T dmthin' exists in stc before preflight is ran and preflight fails don't start. (#1019) * PWX-28826 Boilerplace Signed-off-by: Harsh Desai <hadesai@purestorage.com> * more boilerplate Signed-off-by: Harsh Desai <hadesai@purestorage.com> * PWX-28826: Pre-flight check for DMthin. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Add comments and move StorageNode cleanup. Signed-off-by: Jose Rivera <jose@portworx.com> * Passed checks should be Info events. Signed-off-by: Jose Rivera <jose@portworx.com> * Passed checks should be Info events. (#1010) Signed-off-by: Jose Rivera <jose@portworx.com> * Pwx 28826 (#1011) * Pwx 28826 (#1012) * PWX-28826: Update with the latest master changes. (#1013) * Updating CSV to use 23.3.1 released image * Update for 23.3.1 release * Controller gen vendor Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29389 Add CRD for portworx diags collection Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> * PWX-29409: Ignore zones with no nodes (#1008) In disaggregated mode, there could be zones in which no storage nodes might be present. Such a zone would make the maxSNPZ value to be 0. CHanging the behavior to ignore 0 nodes in a zone for maxSNPZ calculation. Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> --------- Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com> * Add PassPreFlight event tag and logging Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Check status of portworx container in pre-flight pod and remove 'wait' code. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Fix unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Fix unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: PR review changes and fix portworx_test.go UTs Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: fix gomack Validate calls. Also comment out the two tests that don't work since Validate was removed from the controller.validate() func. PWX-30373 to try and fix later. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30373: Re-add back in the commented out tests and add K8s version check failure to trigger the needed workflow. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Exit pre-check wait if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Add 5 min timeout to pre-flight status check. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Exit GetPreFlightStatus() with success if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Don't automatically enable dmthin via pre-flight check if running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30373: Revert UT and integration test hacks. Need to mock the functionality correctly. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: Increase pre-flight daemonset ready wait to 10mins. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826: fix 'TestValidate' UT. Don't error if pre-flight daemonset exists. Signed-off-by: Jose Rivera <jose@portworx.com> * Only run preflight if AWS. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30496: If the user intended to use dmthin. The '-T dmthin' will exist in the stc before preflight is ran. If preflight fails in this case don't start. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30496: If preflight enables DMthin add a 64G metadata drive. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30496: Review fixes. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-30496: add the metadata device in both cases where the user has passed -T dmthin or we added it for them. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Harsh Desai <hadesai@purestorage.com> Signed-off-by: Jose Rivera <jose@portworx.com> Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: Harsh Desai <hadesai@purestorage.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com> * Fix test broken when merged in pre-flight code. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-28826 & PWX-30496: Add ClusterCondition Source to test runs. Signed-off-by: Jose Rivera <jose@portworx.com> * [PWX-27765] Fix migration status update issue --------- Signed-off-by: Harsh Desai <hadesai@purestorage.com> Signed-off-by: Zoran Rajic <zrajic@purestorage.com> Signed-off-by: Jose Rivera <jose@portworx.com> Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Signed-off-by: Naveen Revanna <nrevanna@purestorage.com> Co-authored-by: Harsh Desai <hadesai@purestorage.com> Co-authored-by: Jiafeng Liao <jliao@purestorage.com> Co-authored-by: Zoran Rajic <zox@portworx.com> Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com> Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>

harsh-px and others added 11 commits March 28, 2023 16:07

PWX-28826 Boilerplace

069761b

Signed-off-by: Harsh Desai <hadesai@purestorage.com>

more boilerplate

f8b43c0

Signed-off-by: Harsh Desai <hadesai@purestorage.com>

PWX-28826: Pre-flight check for DMthin.

29d1d99

Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Add comments and move StorageNode cleanup.

f82f027

Signed-off-by: Jose Rivera <jose@portworx.com>

Passed checks should be Info events.

740fc60

Signed-off-by: Jose Rivera <jose@portworx.com>

Passed checks should be Info events. (#1010)

b930040

Signed-off-by: Jose Rivera <jose@portworx.com>

Merge branch 'PWX-28826' of github.com:libopenstorage/operator into P…

e06c9f4

…WX-28826

Pwx 28826 (#1011)

6a0e863

Pwx 28826 (#1012)

94c6226

Merge branch 'master' into PWX-28826

4cb501e

jrivera-px requested review from adityadani, piyush-nimbalkar, prabirpaul, zoxpx and harsh-px April 5, 2023 15:55

github-actions bot added stage/in-review area/components area/controller area/portworx size/l labels Apr 5, 2023

jrivera-px added 4 commits April 6, 2023 00:18

Add PassPreFlight event tag and logging

0ff38ae

Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Check status of portworx container in pre-flight pod and r…

5d0843e

…emove 'wait' code. Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Fix unit test.

766939d

Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Fix unit test.

2b4e04b

Signed-off-by: Jose Rivera <jose@portworx.com>

piyush-nimbalkar reviewed Apr 6, 2023

View reviewed changes

PWX-28826: PR review changes and fix portworx_test.go UTs

c82bd43

Signed-off-by: Jose Rivera <jose@portworx.com>

jrivera-px requested a review from piyush-nimbalkar April 9, 2023 22:57

jrivera-px added 2 commits April 9, 2023 23:17

PWX-28826: fix gomack Validate calls. Also comment out the two tests …

02a5f6c

…that don't work since Validate was removed from the controller.validate() func. PWX-30373 to try and fix later. Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-30373: Re-add back in the commented out tests and add K8s version…

ed4aa58

… check failure to trigger the needed workflow. Signed-off-by: Jose Rivera <jose@portworx.com>

jrivera-px added 4 commits April 10, 2023 19:18

PWX-28826: Exit pre-check wait if running CBT namespace.

e21de49

Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Add 5 min timeout to pre-flight status check.

ff94003

Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Exit GetPreFlightStatus() with success if running CBT name…

c931dae

…space. Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: Don't automatically enable dmthin via pre-flight check if …

3a4b027

…running CBT namespace. Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-30373: Revert UT and integration test hacks. Need to mock the fun…

b55a756

…ctionality correctly. Signed-off-by: Jose Rivera <jose@portworx.com>

github-actions bot added the area/integration-test label Apr 11, 2023

piyush-nimbalkar approved these changes Apr 12, 2023

View reviewed changes

github-actions bot added the stage/approved label Apr 12, 2023

jrivera-px added 3 commits April 12, 2023 20:43

PWX-28826: Increase pre-flight daemonset ready wait to 10mins.

6ec969e

Signed-off-by: Jose Rivera <jose@portworx.com>

PWX-28826: fix 'TestValidate' UT. Don't error if pre-flight daemonset…

528ad6d

… exists. Signed-off-by: Jose Rivera <jose@portworx.com>

Merge branch 'master' into PWX-28826

7bd5f40

jrivera-px mentioned this pull request Apr 16, 2023

Use reconcile loop to check pre-flight status. Timeout after 15m. #1017

Closed

Only run preflight if AWS.

300aee1

Signed-off-by: Jose Rivera <jose@portworx.com>

jrivera-px merged commit f10adb4 into master Apr 17, 2023

jrivera-px mentioned this pull request Apr 25, 2023

PWX-28826 & PWX-30496: Pre-flight check for DMthin #1021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PWX-28826: Handle pre-flight check for DMthin #1014

PWX-28826: Handle pre-flight check for DMthin #1014

jrivera-px commented Apr 5, 2023

piyush-nimbalkar Apr 6, 2023

jrivera-px Apr 8, 2023

piyush-nimbalkar Apr 12, 2023

jrivera-px Apr 12, 2023

codecov bot commented Apr 10, 2023 •

edited

Loading

piyush-nimbalkar Apr 12, 2023

jrivera-px Apr 12, 2023

piyush-nimbalkar Apr 12, 2023

PWX-28826: Handle pre-flight check for DMthin #1014

PWX-28826: Handle pre-flight check for DMthin #1014

Conversation

jrivera-px commented Apr 5, 2023

piyush-nimbalkar Apr 6, 2023

Choose a reason for hiding this comment

jrivera-px Apr 8, 2023

Choose a reason for hiding this comment

piyush-nimbalkar Apr 12, 2023

Choose a reason for hiding this comment

jrivera-px Apr 12, 2023

Choose a reason for hiding this comment

codecov bot commented Apr 10, 2023 • edited Loading

Codecov Report

piyush-nimbalkar Apr 12, 2023

Choose a reason for hiding this comment

jrivera-px Apr 12, 2023

Choose a reason for hiding this comment

piyush-nimbalkar Apr 12, 2023

Choose a reason for hiding this comment

codecov bot commented Apr 10, 2023 •

edited

Loading