PWX-28826 & PWX-30496: Pre-flight check for DMthin

Makefile

@@ -273,6 +273,7 @@ mockgen: $(GOPATH)/bin/gomock $(GOPATH)/bin/mockgen
 	mockgen -destination=pkg/mock/controllermanager.mock.go -package=mock sigs.k8s.io/controller-runtime/pkg/manager Manager
 	mockgen -destination=pkg/mock/controller.mock.go -package=mock sigs.k8s.io/controller-runtime/pkg/controller Controller
 	mockgen -destination=pkg/mock/controllercache.mock.go -package=mock sigs.k8s.io/controller-runtime/pkg/cache Cache
+	mockgen -destination=pkg/mock/preflight.mock.go -package=mock github.com/libopenstorage/operator/pkg/preflight CheckerOps
 
 clean: clean-release-manifest clean-bundle
 	@echo "Cleaning up binaries"

cmd/operator/operator.go

@@ -35,6 +35,7 @@ import (
 	_ "github.com/libopenstorage/operator/pkg/log"
 	"github.com/libopenstorage/operator/pkg/migration"
 	"github.com/libopenstorage/operator/pkg/operator-sdk/metrics"
+	"github.com/libopenstorage/operator/pkg/preflight"
 	"github.com/libopenstorage/operator/pkg/version"
 )
 
@@ -228,7 +229,11 @@ func run(c *cli.Context) {
 		log.Warnf("Failed to expose metrics port: %v", err)
 	}
 
-	if err = d.Init(mgr.GetClient(), mgr.GetScheme(), mgr.GetEventRecorderFor(storagecluster.ControllerName)); err != nil {
+	if err := preflight.InitPreflightChecker(mgr.GetClient()); err != nil {
+		log.Fatalf("Error initializing preflight checker: %v", err)
+	}
+
+	if err := d.Init(mgr.GetClient(), mgr.GetScheme(), mgr.GetEventRecorderFor(storagecluster.ControllerName)); err != nil {
 		log.Fatalf("Error initializing Storage driver %v: %v", driverName, err)
 	}
 

deploy/crds/core_v1_storagecluster_crd.yaml

@@ -3792,6 +3792,9 @@ spec:
                 description: Phase of the StorageCluster is a simple, high-level summary of where the
                   StorageCluster is in its lifecycle. The condition array contains more detailed
                   information about the state of the cluster.
+              reason:
+                type: string
+                description: CamelCase messages split with commas indicating details about why the StorageCluster is in this state.
               collisionCount:
                 type: integer
                 format: int32
@@ -3879,16 +3882,23 @@ spec:
                 items:
                   type: object
                   properties:
+                    source:
+                      type: string
+                      description: Name of the component.
                     type:
                       type: string
                       description: Type of the condition.
                     status:
                       type: string
                       description: Status of the condition.
-                    reason:
+                    message:
                       type: string
-                      description: Reason is human readable message indicating details about the current
+                      description: Message is human readable message indicating details about the current
                         state of the cluster.
+                    lastTransitionTime:
+                      type: string
+                      format: date-time
+                      description: Time at which the condition changed.
   - name: v1alpha1
     served: false
     storage: false

deploy/crds/core_v1_storagenode_crd.yaml

@@ -133,6 +133,21 @@ spec:
                       type: string
                       format: date-time
                       description: Time at which the condition changed.
+              checks:
+                type: array
+                description: Contains list of pre or post flight checks that are performed by the Operator
+                items:
+                  type: object
+                  properties:
+                    type:
+                      type: string
+                      description: Type of the check.
+                    reason:
+                      type: string
+                      description: Reason for success or failure of the check
+                    success:
+                      type: boolean
+                      description: If true, the check was successful
               geography:
                 type: object
                 description: Contains topology information for the storage node.

drivers/storage/portworx/cloud_storage.go

@@ -15,6 +15,9 @@ import (
 	// importing azure cloud provider so that it registers itself
 	// as a provider of the StorageManager interface
 	_ "github.com/libopenstorage/cloudops/azure/storagemanager"
+	// importing aws cloud provider so that it registers itself
+	// as a provider of the StorageManager interface
+	_ "github.com/libopenstorage/cloudops/aws/storagemanager"
 	corev1 "github.com/libopenstorage/operator/pkg/apis/core/v1"
 	"github.com/libopenstorage/operator/pkg/cloudstorage"
 	v1 "k8s.io/api/core/v1"

drivers/storage/portworx/component/disruption_budget.go

@@ -62,7 +62,7 @@ func (c *disruptionBudget) IsEnabled(cluster *corev1.StorageCluster) bool {
 }
 
 func (c *disruptionBudget) Reconcile(cluster *corev1.StorageCluster) error {
-	if cluster.Status.Phase == "" || cluster.Status.Phase == string(corev1.ClusterInit) {
+	if pxutil.IsFreshInstall(cluster) {
 		return nil
 	}
 

drivers/storage/portworx/component/security.go

@@ -500,7 +500,7 @@ func (c *security) closeSdkConn() {
 }
 
 func (c *security) updateSystemGuestRole(cluster *corev1.StorageCluster) error {
-	if cluster.Status.Phase == "" || cluster.Status.Phase == string(corev1.ClusterInit) {
+	if pxutil.IsFreshInstall(cluster) {
 		return nil
 	}
 

drivers/storage/portworx/component/securitycontextconstraints.go

@@ -3,6 +3,9 @@ package component
 import (
 	"context"
 	"fmt"
+	"reflect"
+	"strconv"
+
 	"github.com/hashicorp/go-version"
 	ocp_secv1 "github.com/openshift/api/security/v1"
 	"github.com/sirupsen/logrus"
@@ -12,9 +15,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/tools/record"
-	"reflect"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-	"strconv"
 
 	"k8s.io/apimachinery/pkg/types"
 

drivers/storage/portworx/components_test.go

@@ -4234,8 +4234,9 @@ func TestGuestAccessSecurity(t *testing.T) {
 	err = driver.PreInstall(cluster)
 	require.NoError(t, err)
 
-	// GuestAccess disabled but hould not call update as cluster is still initializing
-	cluster.Status.Phase = string(corev1.ClusterInit)
+	// GuestAccess disabled but should not call update as cluster is still initializing
+	cluster.Status.Phase = string(corev1.ClusterStateInit)
+
 	mockRoleServer.EXPECT().
 		Inspect(gomock.Any(), &osdapi.SdkRoleInspectRequest{
 			Name: component.SecuritySystemGuestRoleName,
@@ -4248,7 +4249,7 @@ func TestGuestAccessSecurity(t *testing.T) {
 
 	// Disable GuestAccess. Should expect an update to be called.
 	cluster.Spec.Security.Auth.GuestAccess = guestAccessTypePtr(corev1.GuestRoleDisabled)
-	cluster.Status.Phase = string(corev1.ClusterOnline)
+	cluster.Status.Phase = string(corev1.ClusterStateRunning)
 	inspectedRole := component.GuestRoleEnabled
 	inspectedRoleResp := &osdapi.SdkRoleInspectResponse{
 		Role: &inspectedRole,
@@ -11081,7 +11082,7 @@ func TestPodDisruptionBudgetEnabled(t *testing.T) {
 			Namespace: "kube-test",
 		},
 		Status: corev1.StorageClusterStatus{
-			Phase: string(corev1.ClusterOnline),
+			Phase: string(corev1.ClusterStateRunning),
 		},
 	}
 
@@ -11281,7 +11282,7 @@ func TestPodDisruptionBudgetWithMetroDR(t *testing.T) {
 			},
 		},
 		Status: corev1.StorageClusterStatus{
-			Phase: string(corev1.ClusterOnline),
+			Phase: string(corev1.ClusterStateRunning),
 		},
 	}
 
@@ -11343,7 +11344,7 @@ func TestPodDisruptionBudgetWithDifferentKvdbClusterSize(t *testing.T) {
 			Namespace: "kube-test",
 		},
 		Status: corev1.StorageClusterStatus{
-			Phase: string(corev1.ClusterOnline),
+			Phase: string(corev1.ClusterStateRunning),
 		},
 	}
 
@@ -11519,7 +11520,7 @@ func TestPodDisruptionBudgetDuringInitialization(t *testing.T) {
 	require.Empty(t, pdbList.Items)
 
 	// TestCase: Do not create PDB if the cluster is initializing
-	cluster.Status.Phase = string(corev1.ClusterInit)
+	cluster.Status.Phase = string(corev1.ClusterStateInit)
 
 	err = driver.PreInstall(cluster)
 	require.NoError(t, err)
@@ -11530,7 +11531,7 @@ func TestPodDisruptionBudgetDuringInitialization(t *testing.T) {
 	require.Empty(t, pdbList.Items)
 
 	// TestCase: Create PDBs when cluster is done initializing
-	cluster.Status.Phase = string(corev1.ClusterOnline)
+	cluster.Status.Phase = string(corev1.ClusterStateRunning)
 
 	err = driver.PreInstall(cluster)
 	require.NoError(t, err)
@@ -11566,7 +11567,7 @@ func TestPodDisruptionBudgetWithErrors(t *testing.T) {
 			},
 		},
 		Status: corev1.StorageClusterStatus{
-			Phase: string(corev1.ClusterOnline),
+			Phase: string(corev1.ClusterStateRunning),
 		},
 	}
 
@@ -11691,7 +11692,7 @@ func TestDisablePodDisruptionBudgets(t *testing.T) {
 			},
 		},
 		Status: corev1.StorageClusterStatus{
-			Phase: string(corev1.ClusterOnline),
+			Phase: string(corev1.ClusterStateRunning),
 		},
 	}