Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-30419: Use reconcile loop to check pre-flight status. Timeout after 15m. #1070

Merged
merged 63 commits into from
Aug 7, 2023

Commits on Mar 28, 2023

  1. PWX-28826 Boilerplace

    Signed-off-by: Harsh Desai <hadesai@purestorage.com>
    harsh-px committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    069761b View commit details
    Browse the repository at this point in the history
  2. more boilerplate

    Signed-off-by: Harsh Desai <hadesai@purestorage.com>
    harsh-px committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    f8b43c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. PWX-28826: Pre-flight check for DMthin.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    29d1d99 View commit details
    Browse the repository at this point in the history
  2. PWX-28826: Add comments and move StorageNode cleanup.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f82f027 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Passed checks should be Info events.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    740fc60 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Passed checks should be Info events. (#1010)

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b930040 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e06c9f4 View commit details
    Browse the repository at this point in the history
  3. Pwx 28826 (#1011)

    jrivera-px committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6a0e863 View commit details
    Browse the repository at this point in the history
  4. Pwx 28826 (#1012)

    jrivera-px committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    94c6226 View commit details
    Browse the repository at this point in the history
  5. PWX-28826: Update with the latest master changes. (#1013)

    * Updating CSV to use 23.3.1 released image
    
    * Update for 23.3.1 release
    
    * Controller gen vendor
    
    Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
    
    * PWX-29389 Add CRD for portworx diags collection
    
    Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
    
    * PWX-29409: Ignore zones with no nodes (#1008)
    
    In disaggregated mode, there could be zones in which no storage nodes
      might be present. Such a zone would make the maxSNPZ value to be 0.
      CHanging the behavior to ignore 0 nodes in a zone for maxSNPZ
      calculation.
    
    Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>
    
    ---------
    
    Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
    Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>
    Co-authored-by: CNBU Jenkins <cnbu-jenkins@purestorage.com>
    Co-authored-by: Jiafeng Liao <jliao@purestorage.com>
    Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
    Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>
    5 people committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0b20b13 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4cb501e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Add PassPreFlight event tag and logging

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    0ff38ae View commit details
    Browse the repository at this point in the history
  2. PWX-28826: Check status of portworx container in pre-flight pod and r…

    …emove 'wait' code.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    5d0843e View commit details
    Browse the repository at this point in the history
  3. PWX-28826: Fix unit test.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    766939d View commit details
    Browse the repository at this point in the history
  4. PWX-28826: Fix unit test.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    2b4e04b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. PWX-28826: PR review changes and fix portworx_test.go UTs

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    c82bd43 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. PWX-28826: fix gomack Validate calls. Also comment out the two tests …

    …that don't work since Validate was removed from the controller.validate() func. PWX-30373 to try and fix later.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    02a5f6c View commit details
    Browse the repository at this point in the history
  2. PWX-30373: Re-add back in the commented out tests and add K8s version…

    … check failure to trigger the needed workflow.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    ed4aa58 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. PWX-28826: Exit pre-check wait if running CBT namespace.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e21de49 View commit details
    Browse the repository at this point in the history
  2. PWX-28826: Add 5 min timeout to pre-flight status check.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    ff94003 View commit details
    Browse the repository at this point in the history
  3. PWX-28826: Exit GetPreFlightStatus() with success if running CBT name…

    …space.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    c931dae View commit details
    Browse the repository at this point in the history
  4. PWX-28826: Don't automatically enable dmthin via pre-flight check if …

    …running CBT namespace.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    3a4b027 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. PWX-30373: Revert UT and integration test hacks. Need to mock the fun…

    …ctionality correctly.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b55a756 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. PWX-28826: Increase pre-flight daemonset ready wait to 10mins.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6ec969e View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. PWX-28826: fix 'TestValidate' UT. Don't error if pre-flight daemonset…

    … exists.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    528ad6d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Configuration menu
    Copy the full SHA
    7bd5f40 View commit details
    Browse the repository at this point in the history
  2. Use reconcile loop to check pre-flight status. Timeout after 15m.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    0ab2abf View commit details
    Browse the repository at this point in the history
  3. PWX-28826: Startup check was not handling if preflight was not enabled.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    5978e4f View commit details
    Browse the repository at this point in the history
  4. PWX-28826: Re-enable preflight for integration tests.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    9cd7f81 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. PWX-28826: disable preflight for integration tests.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    541f6be View commit details
    Browse the repository at this point in the history
  2. PWX-28826: Only do preflight if AWS.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a2e89fa View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. PWX-30496: if '-T dmthin' exists in stc before preflight is ran and …

    …preflight fails don't start. Add default metadata dev for dmthin if it does not exist.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a63a768 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Configuration menu
    Copy the full SHA
    12e3584 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    0757938 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4bfc58 View commit details
    Browse the repository at this point in the history
  3. PWX-28826: Use condition set to determine of CheckCloudDrivePermissio…

    …n check is to be run. Handle skip annotation and pod cleanup.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    953d9fc View commit details
    Browse the repository at this point in the history
  4. PWX-28826: Remove debug logging

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    6f843c3 View commit details
    Browse the repository at this point in the history
  5. PWX-30419: Remove more debug logging.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    90ce4ab View commit details
    Browse the repository at this point in the history
  6. PWX-30419: Revert to correct version.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    37c5281 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. PWX-30419: Fix unit test. Need to enable pre-flight.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    98c2f14 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    f1b6e9b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    434251d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. PWX-30419: Fix TestEKSPreflightCheck unit test. Pre-flight now includ…

    …es DMthin checks so need to handle that.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    03fbb76 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    50b829a View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    f883477 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    4d6cab8 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    92d7b5e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    64b0819 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79b8905 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa1097c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    a8c8f0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55a7d3d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba25d86 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    5a9933f View commit details
    Browse the repository at this point in the history
  2. PWX-28826: Use cluster condition to determine pre-flight status.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    418da07 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. PWX-28826: return cluster condition from driverValidate as that to de…

    …termin status..
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    73d4808 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c7b4b3 View commit details
    Browse the repository at this point in the history
  3. Add err message to default condition message and make sure to use def…

    …ault condition on CloudDrivePermission error.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8d6cf9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ed780b View commit details
    Browse the repository at this point in the history
  5. PWX-28826: Add a constant for pre-flight timeout value.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    602f01b View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. PWX-28826: pre-flight timeout should prevent startup. Add event for t…

    …imeout.
    
    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    eb1862b View commit details
    Browse the repository at this point in the history
  2. PWX-28826: Fix unit tests.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    ee9bc1d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. PWX-28826: Use progress string.

    Signed-off-by: Jose Rivera <jose@portworx.com>
    jrivera-px committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e6659b5 View commit details
    Browse the repository at this point in the history