PWX-31842: PKS mounts-leak fix #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
==========================================
+ Coverage 77.47% 77.49% +0.02%
==========================================
Files 62 62
Lines 17086 17083 -3
==========================================
+ Hits 13237 13239 +2
+ Misses 2922 2919 -3
+ Partials 927 925 -2
☔ View full report in Codecov by Sentry. |
zoxpx
force-pushed
the
PWX-31842_pks_mounts-leak_fix
branch
from
327fcd9
to
f3843e8
Compare
piyush-nimbalkar
approved these changes
Jun 23, 2023
| @@ -51,7 +51,7 @@ spec: | |||
| - name: "PX_TEMPLATE_VERSION" | |||
| value: "v4" | |||
| - name: "PRE-EXEC" | |||
| value: "if [ ! -x /bin/systemctl ]; then apt-get update; apt-get install -y systemd; fi" | |||
| value: "rm -fr /var/lib/osd/driver" | |||
There was a problem hiding this comment.
So, we don't need the old PRE-EXEC command?
There was a problem hiding this comment.
That's correct -- it was added initially to support Ubuntu 14 PKS stemcells, which did not have the systemd package installed. These are "long gone" now -- standard support for Ubuntu 14 LTS version ended beginning of 2019.
zoxpx
force-pushed
the
PWX-31842_pks_mounts-leak_fix
branch
2 times, most recently
from
ccd52c9
to
762abc6
Compare
* mounting changing OSD-mount to `-v /var/lib/osd:/var/vcap/store/lib/osd:shared` * removing offending "pxlogs" (/var/vcap/store/lib/osd/log) mount * changing `PRE-EXEC` to remove the /var/lib/osd/driver directory * fixing UTs Signed-off-by: Zoran Rajic <zrajic@purestorage.com>
|
Thanks Piyush -- merging this PR, cherry-picking for |
zoxpx
added a commit
that referenced
this pull request
Jun 26, 2023
* mounting changing OSD-mount to `-v /var/lib/osd:/var/vcap/store/lib/osd:shared` * removing offending "pxlogs" (/var/vcap/store/lib/osd/log) mount * changing `PRE-EXEC` to remove the /var/lib/osd/driver directory * fixing UTs Signed-off-by: Zoran Rajic <zrajic@purestorage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-v /var/lib/osd:/var/vcap/store/lib/osd:sharedPRE-EXECto remove the /var/lib/osd/driver directoryWhat this PR does / why we need it:
ISSUE: the
/var/lib/osd+/var/lib/osd/logmounts were causing the "mounts leak" issue on PKS platformAs a fix, we are:
/var/vcap/store/lib/osd/var/lib/osd/logmountPRE-EXECto remove /var/lib/osd/driver directory, as thepwx.sockfile inside causes 2-minute delays for everypxctlcommandWhich issue(s) this PR fixes (optional)
Closes # PWX-31842
Special notes for your reviewer: