Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "replaces" version to 23.5.0 for 23.5.1 release #1122

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

nikita-bhatia
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional)
Closes #

Special notes for your reviewer:

@nikita-bhatia nikita-bhatia merged commit b18b20a into px-rel-23.5.1 Jul 11, 2023
7 checks passed
@zoxpx
Copy link
Collaborator

zoxpx commented Jul 11, 2023

Thanks for fixing this Nikita

@piyush-nimbalkar piyush-nimbalkar deleted the update-prev-version branch July 11, 2023 07:56
@piyush-nimbalkar
Copy link
Member

23.5.0 had issues with preflight, so we had decided to purposely skip it. That's we put replaces as 23.4.0 so that users on 23.4.0 will directly get upgraded to 23.5.1.

Can you confirm with the QA team on how the upgrade hops were tested?

@nikita-bhatia
Copy link
Contributor Author

23.5.0 had issues with preflight, so we had decided to purposely skip it. That's we put replaces as 23.4.0 so that users on 23.4.0 will directly get upgraded to 23.5.1.

Can you confirm with the QA team on how the upgrade hops were tested?

@piyush-nimbalkar we were hitting following issue when trying to update with replaces as 23.4.0,

ERROR: /root/workspace/Release/px-operator/operator/deploy/olm-catalog/portworx/23.5.1/portworx-certified.clusterserviceversion.yaml file has wrong previous version in 'replaces' parameter!
Expected version: 23.5.0
Actual version: replaces: portworx-operator.v23.4.0

@piyush-nimbalkar
Copy link
Member

23.5.0 had issues with preflight, so we had decided to purposely skip it. That's we put replaces as 23.4.0 so that users on 23.4.0 will directly get upgraded to 23.5.1.
Can you confirm with the QA team on how the upgrade hops were tested?

@piyush-nimbalkar we were hitting following issue when trying to update with replaces as 23.4.0,

ERROR: /root/workspace/Release/px-operator/operator/deploy/olm-catalog/portworx/23.5.1/portworx-certified.clusterserviceversion.yaml file has wrong previous version in 'replaces' parameter! Expected version: 23.5.0 Actual version: replaces: portworx-operator.v23.4.0

I discussed this with Maksym. We should have passed 23.4.0 as the previous version when starting the release pipeline to avoid this error. The replaces in the CSV and the above assertion would have then matched.
We should do this only when we know that we have to skip a particular release due to some bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants