PWX-32177: Removes unnecessary permissions from diag collector pods #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyush-nimbalkar
approved these changes
Jul 19, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
+ Coverage 76.10% 76.12% +0.01%
==========================================
Files 64 64
Lines 17936 17932 -4
==========================================
Hits 13651 13651
+ Misses 3326 3322 -4
Partials 959 959
☔ View full report in Codecov by Sentry. |
ggriffiths
approved these changes
Jul 19, 2023
Pure-AdamuKaapan
force-pushed
the
PWX-32177
branch
2 times, most recently
from
afc715a
to
57c5513
Compare
Pure-AdamuKaapan
force-pushed
the
PWX-32177
branch
from
57c5513
to
03ec822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Like the last PR, the pod spec was mostly copied from the standard portworx pod spec. This left some extra things like HostNetwork, DNSPolicy, and EnableServiceLinks that we don't need.
I again confirmed it worked by checking the size of a diag before and after the change and they were nearly identical, confirming all the same data is still there.
Which issue(s) this PR fixes (optional)
PWX-32177