PWX-32188: TLS cipher-suite/version annotations #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 76.12% 76.11% -0.02%
==========================================
Files 64 64
Lines 17932 17980 +48
==========================================
+ Hits 13651 13685 +34
- Misses 3322 3328 +6
- Partials 959 967 +8
☔ View full report in Codecov by Sentry. |
piyush-nimbalkar
approved these changes
Jul 19, 2023
| } | ||
| req = strings.Trim(req, " \t") | ||
|
|
||
| if req == "VersionTLS10" || req == "VersionTLS11" || req == "VersionTLS12" || req == "VersionTLS13" { |
There was a problem hiding this comment.
nit: Is this a case insensitive string? If yes, should we do a case insensitive match too?
* adding annotations to select TLS version and cipher-suites for kube-controller-manager Signed-off-by: Zoran Rajic <zox@portworx.com>
zoxpx
force-pushed
the
PWX-32188_tls_annotations
branch
from
8219b8b
to
06111b0
Compare
|
Thanks for the review Piyush -- merging this PR, cherry-picking for px-rel-23.7.0 |
zoxpx
added a commit
that referenced
this pull request
Jul 21, 2023
* adding annotations to select TLS version and cipher-suites for kube-controller-manager Signed-off-by: Zoran Rajic <zox@portworx.com> Manualy fixed Conflicts: drivers/storage/portworx/util/util.go drivers/storage/portworx/util/util_test.go
nrevanna
pushed a commit
that referenced
this pull request
Aug 7, 2023
* adding annotations to select TLS version and cipher-suites for kube-controller-manager Signed-off-by: Zoran Rajic <zox@portworx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Customers requested to fine-tune the TLS cipher-suites
FIX:
portworx.io/tls-cipher-suitesannotation to select the TLS cipher suitesportworx.io/tls-min-versionannotation to select the minimal TLS versionportworx-pvc-controller-manager-- but we should extend it to all TLS-enabled services in PX deploymentAlso note:
Which issue(s) this PR fixes (optional)
Closes # PWX-32188
Special notes for your reviewer:
New annotations look like this:
As a result, the parameters are added to the
kube-controller-managercommand:kubectl get pod -Al name=portworx-pvc-controller