PWX-31625 : Disable pvc-controller for openshift cluster

[nikita-bhatia]

Disabling PVC controller for openshift since Openshift already has kube-controller maanger.
Having additional kube-controller ends up spamming vcenter with storage tasks.

Tests done :

• Tested on Rh Openshift cluster 4.12.22
• pvc-controller is not created and portworx is deployed fine

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f2a7fbd) 76.08% compared to head (d049f52) 76.08%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   76.08%   76.08%           
=======================================
  Files          64       64           
  Lines       18032    18033    +1     
=======================================
+ Hits        13720    13721    +1     
  Misses       3342     3342           
  Partials      970      970           

Files Changed	Coverage Δ
...rivers/storage/portworx/component/pvccontroller.go	91.52% <100.00%> (+0.02%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[piyush-nimbalkar]

We would want to deploy the pvc controller if portworx is not deployed in the kube-system namespace. Without that portworx volume will not get deployed.

@nikita-bhatia to verify this ticket, you will have to create a non CSI px volume and check that it gets provisioned. Just deploying px won't tell us anything.

[github-actions]

This PR is stale because it has been in review for 3 days with no activity.

[ggriffiths]

Needs additional testing as per earlier comment

[camartinez04]

I can create new PVCs without PX PVC Controller Manager being present on OpenShift (note that we need access to the master nodes) with Portworx deployed on a non kube-system namespace such as portworx. It uses the master node controller. @ggriffiths

[github-actions]

This PR is stale because it has been in review for 3 days with no activity.

[camartinez04]

This issue is still happening with more people getting affected

[github-actions]

This PR is stale because it has been in review for 3 days with no activity.

[zoxpx]

Woops -- looks like I missed this PR, and just re-fixed it @ #1297

I'll just close this one.