PTX-18831 Improving logic for when Telemetry should be enabled/disabled

[nikolaypopov]

Improving logic for when Telemetry should be enabled/disabled

[ezhang-px]

some of the APIs (GetPxProxyEnvVarValue, CanAccessArcusRegisterEndpoint, ParsePxProxyURL, IsCCMGoSupported) are redefined in other packages: drivers/storage/portworx/component, drivers/storage/portworx/util with even different implementation, can we simply call them for the test purpose instead of rewriting?

[nikolaypopov]

some of the APIs (GetPxProxyEnvVarValue, CanAccessArcusRegisterEndpoint, ParsePxProxyURL, IsCCMGoSupported) are redefined in other packages: drivers/storage/portworx/component, drivers/storage/portworx/util with even different implementation, can we simply call them for the test purpose instead of rewriting?

I tried that and it is not possible due to import cycle not allowed, also as per @piyush-nimbalkar we do not want to re-use much of operator functions, just in case a bug is introduced there.

[ezhang-px]

some of the APIs (GetPxProxyEnvVarValue, CanAccessArcusRegisterEndpoint, ParsePxProxyURL, IsCCMGoSupported) are redefined in other packages: drivers/storage/portworx/component, drivers/storage/portworx/util with even different implementation, can we simply call them for the test purpose instead of rewriting?

I tried that and it is not possible due to import cycle not allowed, also as per @piyush-nimbalkar we do not want to re-use much of operator functions, just in case a bug is introduced there.

Got you, thanks for the explanation. @jrivera-px also described more context to me offline about what's going yesterday. Just one catch here about the CanAccessArcusRegisterEndpoint, I think in the current release, it's already updated, so is it on purpose that we have to use the code before the https changes?
https://github.com/libopenstorage/operator/blob/px-rel-23.7.0/drivers/storage/portworx/component/telemetry.go#L1036

[ezhang-px]

LGTM