PWX-32539: When preflight enables PX-storeV2 for vsphere. It should … #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided. Signed-off-by: Jose Rivera <jose@portworx.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
- Coverage 76.08% 75.82% -0.26%
==========================================
Files 64 64
Lines 18032 18099 +67
==========================================
+ Hits 13720 13724 +4
- Misses 3342 3402 +60
- Partials 970 973 +3
☔ View full report in Codecov by Sentry. |
prabirpaul
approved these changes
Jul 26, 2023
nrevanna
approved these changes
Jul 26, 2023
Signed-off-by: Jose Rivera <jose@portworx.com>
prabirpaul
approved these changes
Jul 27, 2023
jrivera-px
added a commit
that referenced
this pull request
Jul 27, 2023
…#1167) * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should add a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: Change name of default metadata drive const for AWS. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com>
jrivera-px
added a commit
that referenced
this pull request
Jul 27, 2023
#1170) * PWX-32567: pre-flight pods do not run on master so don't create pre-flight storage node entry for master. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32567: Add additional logging to update storage cluster error for debugging. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should … (#1167) * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should add a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: Change name of default metadata drive const for AWS. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>
jrivera-px
added a commit
that referenced
this pull request
Jul 31, 2023
#1170) * PWX-32567: pre-flight pods do not run on master so don't create pre-flight storage node entry for master. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32567: Add additional logging to update storage cluster error for debugging. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should … (#1167) * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should add a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: Change name of default metadata drive const for AWS. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>
jrivera-px
added a commit
that referenced
this pull request
Jul 31, 2023
* PWX-32567: pre-flight pods do not run on master so don't create pre-f… (#1170) * PWX-32567: pre-flight pods do not run on master so don't create pre-flight storage node entry for master. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32567: Add additional logging to update storage cluster error for debugging. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should … (#1167) * PWX-32539: When preflight enables PX-storeV2 for vsphere. It should add a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32539: Change name of default metadata drive const for AWS. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com> * fix merge conflict. --------- Signed-off-by: Jose Rivera <jose@portworx.com> Co-authored-by: Naveen Revanna <83608369+nrevanna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…add a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided.
What this PR does / why we need it:
Preflight should add a default 'type=eagerzeroedthick,size=64' SystemMdDeviceSpec if none is provided. When running on vsphere.
Which issue(s) this PR fixes (optional)
Closes #
PWX-32539
Special notes for your reviewer: