Merge PWX-32428,PWX-27672 fixes into 23.7.0 (#1141) (#1181) #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New functionality triggered via `portworx.io/privileged = false` annotation:
* Portworx PODs (oci-monitors) no longer using `privileged:true` - but using 5 capabilities instead
* we're also disabling all Bidirectional-mounts, and converting them to regular-mounts (warning will indicate to change STC...privileged=true to enable back)
Signed-off-by: Zoran Rajic <zox@portworx.com>
Manually fixed Conflicts:
drivers/storage/portworx/util/util.go
pkg/controller/storagecluster/storagecluster.go
…1181) * fixes shared mounts for PKS (PWX-32428, regression introduced via PWX-31842) * fixed shared mounts for privileged:false (PWX-27672) Signed-off-by: Zoran Rajic <zox@portworx.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## px-rel-23.7.0 #1185 +/- ##
=================================================
+ Coverage 80.22% 80.23% +0.01%
=================================================
Files 58 58
Lines 16442 16485 +43
=================================================
+ Hits 13190 13227 +37
- Misses 2330 2334 +4
- Partials 922 924 +2
☔ View full report in Codecov by Sentry. |
|
Travis-checks passed, will merge without review (since these are cherry-picks that have already been reviewed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zoran Rajic zox@portworx.com
What this PR does / why we need it:
Merging fixes PWX-32428,PWX-27672 from
master-branch :Which issue(s) this PR fixes (optional)
Closes # PWX-32428, PWX-27672
Special notes for your reviewer: