Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-32773: OCP-4.13 non-privileged deployment fix #1186

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

zoxpx
Copy link
Collaborator

@zoxpx zoxpx commented Aug 7, 2023

Adding SYS_CHROOT capability into non-privileged deployment

What this PR does / why we need it:

PX deployment with privileged:false annotation was failing on the OCP-4.13.

FIX:

  • we're adding SYS_CHROOT capability into the requested capabilities -- this enables deployment on OCP-4.13

Which issue(s) this PR fixes (optional)
Closes # PWX-32773

Special notes for your reviewer:

Adding SYS_CHROOT capability into non-privileged deployment

Signed-off-by: Zoran Rajic <zox@portworx.com>
Copy link
Contributor

@nikita-bhatia nikita-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9780d6b) 80.23% compared to head (422f3f4) 80.23%.

Additional details and impacted files
@@              Coverage Diff               @@
##           px-rel-23.7.0    #1186   +/-   ##
==============================================
  Coverage          80.23%   80.23%           
==============================================
  Files                 58       58           
  Lines              16485    16485           
==============================================
  Hits               13227    13227           
  Misses              2334     2334           
  Partials             924      924           
Files Changed Coverage Δ
drivers/storage/portworx/deployment.go 95.78% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoxpx
Copy link
Collaborator Author

zoxpx commented Aug 7, 2023

Thanks Nikita -- merging this PR, will cherry-pick to master-branch

@zoxpx zoxpx merged commit 735f9d8 into px-rel-23.7.0 Aug 7, 2023
8 checks passed
@zoxpx zoxpx deleted the PWX-32773_ocp_non-privileged_fix branch August 7, 2023 09:43
zoxpx added a commit that referenced this pull request Aug 7, 2023
Adding SYS_CHROOT capability into non-privileged deployment

Signed-off-by: Zoran Rajic <zox@portworx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants