remove backticks and LDFLAG variable name to fix vulnerability

[nikita-bhatia]

Following changes are for vulnerability fixes CVE-2023-24538 , CVE-2023-29404, CVE-2023-29405

1. Removed few backticks (“” -chars) and replaced with "or'`

2. Re the usage of LDFLAGS variable (we use it as a regular variable in a Makefile, no special meaning, since we’re not compiling any C/C++ code as a part of operator)

Note : Testing still needs to be done

[zoxpx]

This looks OK -- thanks Nikita.

Please remember to update that .travis.yml -script

[zoxpx]

Good that you caught it. 👍

[zoxpx]

LOL -- this is too funny -- now the Travis and staticcheck are asking to return the "the executable-backticks" back:

go run github.com/golangci/golangci-lint/cmd/golangci-lint run --timeout=5m ./...
pkg/util/test/util.go:490:13: S1007: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (gosimple)
					ver := regexp.MustCompile("\\S+\\/(\\d.\\S+)\\/version").FindStringSubmatch(env.Value)
					       ^
pkg/migration/generate.go:1189:20: S1007: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (gosimple)
	validNameRegex := regexp.MustCompile("^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$")
	                  ^
pkg/util/util.go:100:25: S1007: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (gosimple)
	hostnameWithDomainRe = regexp.MustCompile("^(?i)[a-z0-9-]+(\\.[a-z0-9-]+)+\\.?$")
	                       ^

We'll probably need to add //lint:ignore S1007 to skip these 3 occurrences of the complaint.

[zoxpx]

Looking good -- but, you might need to rebase the PR, to make the Travis happy...

[nikita-bhatia]

Looking good -- but, you might need to rebase the PR, to make the Travis happy...

Travis is still failing because of same issue , after adding lint:ignore, staticcheck looks fine but lint is still complaining about same issue

 S1007: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (gosimple)
					ver := regexp.MustCompile("\\S+\\/(\\d.\\S+)\\/version").FindStringSubmatch(env.Value) //lint:ignore S1007 we want to remove backticks to avoid vulnerability 

[github-actions]

This PR is stale because it has been in review for 3 days with no activity.

[github-actions]

This PR is stale because it has been open for 90 days with no activity. Update this PR or it will be automatically closed in 30 days.