PWX-32732 : use portworx-restricted based on IsPrivileged flag #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoxpx
requested changes
Aug 8, 2023
nikita-bhatia
force-pushed
the
PWX-32732
branch
from
b4c4aec
to
df61352
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## px-rel-23.7.0 #1191 +/- ##
==============================================
Coverage 80.03% 80.03%
==============================================
Files 58 58
Lines 16580 16583 +3
==============================================
+ Hits 13269 13272 +3
Misses 2379 2379
Partials 932 932
☔ View full report in Codecov by Sentry. |
zoxpx
approved these changes
Aug 9, 2023
| ) | ||
| } | ||
|
|
||
| return k8sutil.CreateOrUpdateClusterRole(c.k8sClient, clusterRole) |
There was a problem hiding this comment.
This seems to be a new addition... was this a mistake, or was this line required ?
There was a problem hiding this comment.
This method was returning k8sutil.CreateOrUpdateClusterRole , moved it to last line to add conditional statement of SCC name before creating the cluster role.
nikita-bhatia
added a commit
that referenced
this pull request
Aug 9, 2023
* use portworx-restricted based on IsPrivileged flag * Add UTs for install with non-privileged annotation * Add UTs for install with non-privileged annotation * remove debug logs
nikita-bhatia
added a commit
that referenced
this pull request
Aug 9, 2023
* PWX-32732 : use SCC based on IsPrivileged flag (#1191) * use portworx-restricted based on IsPrivileged flag * Add UTs for install with non-privileged annotation * Add UTs for install with non-privileged annotation * remove debug logs * resolve conflict * fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do not use portworx-restricted SCC by default, use the old way and allow to enable/disable it via annotation
Which issue(s) this PR fixes (optional)
Closes # https://portworx.atlassian.net/browse/PWX-32732