PWX-32850: When preflight is unsupported we need to make sure we are … #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting the pre-flight annotation to false. Signed-off-by: Jose Rivera <jose@portworx.com>
nrevanna
approved these changes
Aug 9, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
- Coverage 75.68% 75.68% -0.01%
==========================================
Files 64 64
Lines 18250 18249 -1
==========================================
- Hits 13813 13812 -1
Misses 3453 3453
Partials 984 984
☔ View full report in Codecov by Sentry. |
jrivera-px
added a commit
that referenced
this pull request
Aug 10, 2023
…setting the pre-flight annotation to false. (#1195) Signed-off-by: Jose Rivera <jose@portworx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…setting the pre-flight annotation to false.
What this PR does / why we need it:
When preflight was not supposed to be run. We were only setting the annotation to false when the annotation did not exist. Problem here was it existed and was set to "true". This prevented the cluster configuration changes from being applied since it continually though preflight should be run. The fix is to make sure preflight annotation is set to false when pre-flight is not supported.
Which issue(s) this PR fixes (optional)
Closes #
PWX-32850
Special notes for your reviewer: