Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a constant for the diag 'Deleting' state. Only used in other repos #1197

Closed

Conversation

Pure-AdamuKaapan
Copy link
Contributor

What this PR does / why we need it:
Will simply be used to replace a hardcoded string in other repos.

@github-actions
Copy link

This PR is stale because it has been in review for 3 days with no activity.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (de9416f) 75.85% compared to head (4abd941) 75.68%.

❗ Current head 4abd941 differs from pull request most recent head faeee28. Consider uploading reports for the commit faeee28 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   75.85%   75.68%   -0.18%     
==========================================
  Files          65       64       -1     
  Lines       18523    18249     -274     
==========================================
- Hits        14051    13812     -239     
+ Misses       3466     3453      -13     
+ Partials     1006      984      -22     

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 5, 2024

This PR is stale because it has been open for 90 days with no activity. Update this PR or it will be automatically closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants