Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWX-32648: Adding Install/Uninstall test cases #1198

Merged
merged 1 commit into from
Aug 16, 2023
Merged

PWX-32648: Adding Install/Uninstall test cases #1198

merged 1 commit into from
Aug 16, 2023

Conversation

nrevanna
Copy link
Contributor

@nrevanna nrevanna commented Aug 10, 2023 •
edited
Loading

Install/Uninstall tests for PX-StoreV2

https://portworx.testrail.net/index.php?/runs/view/6624&group_by=cases:custom_automated&group_order=asc

The above link has a bunch of tests where we try different
combinations of the below to make sure dmthin is installed.

  • Journal device
  • KVDB device
  • Auto Journal
  • Metadata Device
  • -T px-storev2 option

Two operator integration tests are added to enforce the above
combinations and have 32 tests

What this PR does / why we need it:

Which issue(s) this PR fixes (optional)
Closes #

Special notes for your reviewer:
Testing notes:

Two jenkins jobs were created to run the two tests added

https://jenkins.pwx.dev.purestorage.com/job/3.1.0-dev-jobs/job/vSphere-withDmthinOption-opint/
https://jenkins.pwx.dev.purestorage.com/job/3.1.0-dev-jobs/job/vSphere-withoutDmthinOption-opint/

03:37:38.050 --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option (11421.00s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWith (844.20s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithJournal (673.06s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithKVDB (693.04s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithKVDBJournal (702.12s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithAutoJournal (734.20s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithJournal#01 (679.31s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithKVDBAutoJournal (677.09s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithKVDBJournal#01 (706.08s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadata (708.01s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataJournal (710.05s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataKVDB (734.97s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataKVDBJournal (696.86s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataAutoJournal (764.05s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataJournal#01 (791.08s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataKVDBAutoJournal (642.00s)
03:37:38.050     --- PASS: TestStorageClusterDmthinWithoutPxStoreV2Option/BasicInstallDmthinWithMetadataKVDBJournal#01 (664.88s)
03:37:38.050 PASS

The other run

03:52:56.263 --- PASS: TestStorageClusterDmthinWithPxStoreV2Option (12440.27s)
03:52:56.263     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2 (1088.56s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2Journal (874.29s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2KVDB (840.28s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2KVDBJournal (752.21s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2AutoJournal (668.40s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2Journal#01 (758.27s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2KVDBAutoJournal (791.20s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2KVDBJournal#01 (733.33s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2Metadata (763.04s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataJournal (691.03s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataKVDB (781.24s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataKVDBJournal (703.26s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataAutoJournal (731.28s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataJournal#01 (754.38s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataKVDBAutoJournal (721.23s)
03:52:56.267     --- PASS: TestStorageClusterDmthinWithPxStoreV2Option/BasicInstallDmthinWithPxStoreV2MetadataKVDBJournal#01 (788.27s)
03:52:56.267 PASS

@nrevanna nrevanna requested review from a team August 10, 2023 05:04
@github-actions
Copy link

This PR is stale because it has been in review for 3 days with no activity.

Pure-AdamuKaapan
Pure-AdamuKaapan reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@Pure-AdamuKaapan Pure-AdamuKaapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the testing methodology overall! A few nits as far as the case generation but should be easy to fix

test/integration_test/basic_dmthin_test.go Outdated Show resolved Hide resolved
test/integration_test/utils/utils.go Outdated Show resolved Hide resolved
test/integration_test/utils/utils.go Outdated Show resolved Hide resolved
test/integration_test/basic_dmthin_test.go Outdated Show resolved Hide resolved
pp511
pp511 reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. And much needed I feel.
Just some nits and questions.

test/integration_test/basic_dmthin_test.go Show resolved Hide resolved
test/integration_test/utils/utils.go Show resolved Hide resolved
test/integration_test/basic_dmthin_test.go Outdated Show resolved Hide resolved
pp511
pp511 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nrevanna
PWX-32648: Adding Install/Uninstall test cases
511efd7 
  Install/Uninstall tests for PX-StoreV2
  https://portworx.testrail.net/index.php?/runs/view/6624&group_by=cases:custom_automated&group_order=asc

  The above link has a bunch of tests where we try different
  combinations of the below to make sure dmthin is installed.
  - Journal device
  - KVDB device
  - Auto Journal
  - Metadata Device
  - -T px-storev2 option

  Two operator integration tests are added to enforce the above
  combinations and have 32 tests

Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>
Pure-AdamuKaapan
Pure-AdamuKaapan approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Pure-AdamuKaapan Pure-AdamuKaapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nrevanna nrevanna merged commit 2efec6b into master Aug 16, 2023
9 checks passed
@nrevanna nrevanna deleted the PWX-32648-master branch August 16, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp511 pp511 pp511 approved these changes

@Pure-AdamuKaapan Pure-AdamuKaapan Pure-AdamuKaapan approved these changes

Assignees
No one assigned
Labels
area/integration-test size/m stage/approved stage/in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nrevanna @pp511 @Pure-AdamuKaapan