PWX-32580: Do not create pre-flight storage node objects for nodes wh… #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich have label px/enabled=false. Signed-off-by: Jose Rivera <jose@portworx.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1222 +/- ##
==========================================
+ Coverage 75.77% 75.82% +0.04%
==========================================
Files 65 65
Lines 18410 18422 +12
==========================================
+ Hits 13951 13968 +17
+ Misses 3464 3455 -9
- Partials 995 999 +4
☔ View full report in Codecov by Sentry. |
…e-flight storage node based on this api check. Signed-off-by: Jose Rivera <jose@portworx.com>
|
Latest runs on OCP worked ... |
harsh-px
previously requested changes
Aug 22, 2023
Comment on lines
449
to
455
| shouldRun, _, err := c.nodeShouldRunStoragePod(&node, toUpdate) | ||
| if err == nil { | ||
| if shouldRun { | ||
| logrus.Infof("Create pre-flight storage node entry for node: %s", node.Name) | ||
| c.createStorageNode(toUpdate, node.Name) | ||
| } else { | ||
| logrus.Infof("Skipping pre-flight storage node entry for node: %s", node.Name) |
There was a problem hiding this comment.
Please add UTs to cover the diff here.
nrevanna
reviewed
Aug 22, 2023
There was a problem hiding this comment.
@jrivera-px does this also take care of infra nodes in OCP scenario?
… unit test. Signed-off-by: Jose Rivera <jose@portworx.com>
harsh-px
reviewed
Aug 23, 2023
| for _, node := range k8sNodeList.Items { | ||
| shouldRun, _, err := c.nodeShouldRunStoragePod(&node, toUpdate) | ||
| if err != nil { | ||
| logrus.Infof("Skipping pre-flight storage node entry for %s node. Error: %v", node.Name, err) |
There was a problem hiding this comment.
The Infof should be an warnf instead as this is not expected. Not error since we aren't failing the operator due to this.
Signed-off-by: Jose Rivera <jose@portworx.com>
|
@nrevanna sorry didn't answer this "does this also take care of infra nodes in OCP scenario?".... Yes it does. |
jrivera-px
added a commit
that referenced
this pull request
Aug 26, 2023
#1222) * PWX-32580: Do not create pre-flight storage node objects for nodes which have label px/enabled=false. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32580: Use correct api to check if a node will run px. Create pre-flight storage node based on this api check. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32580: break out pre-flight storage node create/delete funcs. Add unit test. Signed-off-by: Jose Rivera <jose@portworx.com> * PWX-32580: PR suggestion change infof to warnf on skips. Signed-off-by: Jose Rivera <jose@portworx.com> --------- Signed-off-by: Jose Rivera <jose@portworx.com>
jrivera-px
added a commit
that referenced
this pull request
Aug 28, 2023
#1222) (#1233) * PWX-32580: Do not create pre-flight storage node objects for nodes which have label px/enabled=false. * PWX-32580: Use correct api to check if a node will run px. Create pre-flight storage node based on this api check. * PWX-32580: break out pre-flight storage node create/delete funcs. Add unit test. * PWX-32580: PR suggestion change infof to warnf on skips. --------- Signed-off-by: Jose Rivera <jose@portworx.com>
piyush-nimbalkar
deleted the
PWX-32580-preflight-skip-px-disabled-nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ich have label px/enabled=false.
What this PR does / why we need it:
If pre-flight storage node exists it should have status results provided by the pre-flight pod run. If not we will assume pre-flight failed to run on that node and we will fail pre-flight. We create storage nodes objects for all nodes except for master. However when label px/enabled=false is supplied on a node, pre-flight will not run on this node. This resulted in that node not having any results and we fail pre-flight. So don't create storage node object for nodes with PX disabled label."
Which issue(s) this PR fixes (optional)
Closes #
PWX-32580
Special notes for your reviewer: