Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust-libp2p): update required jobs #198

Closed
wants to merge 6 commits into from
Closed

feat(rust-libp2p): update required jobs #198

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a930ccb
Update libp2p.yml
thomaseizinger Nov 20, 2023
ec8355c
fix@6925181321 [skip fix]
thomaseizinger Nov 20, 2023
8851f56
Update github/libp2p.yml
thomaseizinger Nov 20, 2023
11f529f
Merge branch 'master' into patch-9
galargh Jan 3, 2024
6e988eb
Merge branch 'master' into patch-9
galargh Jan 3, 2024
a5c23be
Merge branch 'master' into patch-9
libp2p-mgmt-read-write[bot] Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions github/libp2p.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6499,6 +6499,13 @@ repositories:
default_branch: main
delete_branch_on_merge: true
description: The JavaScript Implementation of libp2p networking stack.
files:
.github/pull_request_template.md:
content: .github/js_pull_request_template.md
.github/workflows/semantic-pull-request.yml:
content: .github/workflows/semantic-pull-request.yml
.github/workflows/stale.yml:
content: .github/workflows/stale.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is doing in my PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achingbrain @galargh do you why automation pushed these changes to an unrelated pull request?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automation runs https://github.com/libp2p/github-mgmt/blob/master/scripts/src/actions/fix-yaml-config.ts after every push to the default branch and on every PR.

The reason why unrelated changes were pushed to the PR was that #197 has not been merged. The timeline would be, 1. the sync workflow discovers divergence between what's in this repo and the actual GitHub state, 2. the repo gets updated, 3. the PR with fixes is created but not merged, 4. this PR is created, 5. the fixes are also proposed in this PR because the PR with fixes was not merged yet.

Another thing to note is that once a fix PR is merged, then all the existing PRs are rebased which would have got rid of the unrelated changes.

It is a bit clunky at the moment. I'd like to package the workflows that do the actual work in this repo into nice reusable actions so it'd be easier for users to reason about and customise what happens when. There's no timeline for that work though.

Another issue, the commits with fixes are associated with PR owner at the moment which shouldn't be the case as they are bot commits. I created an issue for that here - ipdxco/github-as-code#110

has_discussions: true
merge_commit_message: PR_TITLE
merge_commit_title: MERGE_MESSAGE
Expand Down Expand Up @@ -7275,14 +7282,14 @@ repositories:
contexts:
- Check for changes in proto files
- Check rustdoc intra-doc links
- Compile libp2p in transport feature matrix
- Compile libp2p-identity in feature matrix
- Compile on wasm32-unknown-emscripten
- Compile on wasm32-unknown-unknown
- Compile on wasm32-wasi
- Compile on x86_64-apple-darwin
- Compile on x86_64-pc-windows-msvc
- Compile with MSRV
- Compile with select features (mdns tcp dns async-std)
- Compile with select features (mdns tcp dns tokio)
- Ensure that `Cargo.lock` is up-to-date
- examples
- IPFS Integration tests
Expand Down