This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
Background trimming #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix potential concurrent modification of connection map from concurrent connects/disconnects by locking the segment - don't spawn goroutines on every connect during trims
otherwise the target can be 0, which makes it negative on decrement, and it will end up dropping all connections.
ghost
assigned 
vyzo
force-pushed
the
feat/background-trimming
branch
from
1e96efe
to
dc99664
Compare
Stebalien
approved these changes
May 18, 2019
|
I am waiting for libp2p/go-libp2p-interface-connmgr#18 before merge, so that we can absorb the interface change as well. |
|
Merging this, as the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #40
Closes #42
Closes #44
Note that this adds a
Closemethod to stop the background goroutine; that should be part of the connection manager interface and invoked by the host on close.