This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Fix documentation missmatch for crypto methods. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs seem to lie about what these methods do. This is the naive solution since it's my first day looking at go but would it be possible to get these methods to marshal to public or private key correctly by passing a type to them?
JorikSchellekens
changed the title
|
This is not covered by #2 |
|
Also, I've no idea what the codecov is complaining about. This is a doc only change so far. |
|
Would it make more sense to just have methods for both PrivateKeys and PublicKeys? |
Stebalien
approved these changes
Dec 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs seem to lie about what the
ConfigEncodeKeyandConfigDecodeKeymethods do. Currently they seem to simply be wrappers around base 64 encoding and decoding.The simple fix is to update the docs but is it possible to get these methods
to marshal to public or private key correctly by passing a "type" (reflect.Type or something) to them?
(First day using go, otherwise I would have taken an actual stab at this)