Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGetFailures sometimes fails #431

Closed
aschmahmann opened this issue Dec 17, 2019 · 1 comment
Closed

TestGetFailures sometimes fails #431

aschmahmann opened this issue Dec 17, 2019 · 1 comment

Comments

@aschmahmann
Copy link
Contributor

TestGetFailures sometimes fails. When running tests with -race it's very easy to trigger the failure.

func TestGetFailures(t *testing.T) {

=== RUN   TestGetFailures
panic: io: read/write on closed pipe

goroutine 274 [running]:
github.com/libp2p/go-libp2p-kad-dht.TestGetFailures.func2(0x102e820, 0xc000004460)
        C:/Users/adin/go/src/github.com/libp2p/go-libp2p-kad-dht/ext_test.go:72 +0x
48f
github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).SetStreamHandler.func1(0xc0
00018150, 0xf, 0x5900030, 0xc000004460, 0xf, 0xc000054220)
        C:/Users/adin/go/pkg/mod/github.com/libp2p/go-libp2p@v0.4.2/p2p/host/basic/
basic_host.go:393 +0xbc
created by github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).newStreamHandler

        C:/Users/adin/go/pkg/mod/github.com/libp2p/go-libp2p@v0.4.2/p2p/host/basic/
basic_host.go:291 +0x873
exit status 2

The tests fails occur at

if err := pbr.ReadMsg(pmes); err != nil {
panic(err)

@Stebalien
Copy link
Member

Discussed in person. Conclusion: ignore the error.

Stebalien added a commit that referenced this issue Apr 3, 2020
The querying node _is_ allowed to reset and go away.

fixes #431
Stebalien added a commit that referenced this issue Apr 3, 2020
The querying node _is_ allowed to reset and go away.

fixes #431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants