feat: increase expiration time for Provider Records to 48h (RFM17) #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2022
Merged
6 tasks
lidel
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
lgtm, this PR is in sync with spec changes proposed in libp2p/specs#451
@marten-seemann any concerns about this and #794?
Are you able to make a release of go-libp2p-kad-dht with this, so I can include it in Kubo 0.18(ipfs/kubo#9417)?
(If you are busy with other stuff I can do the release chores, but need your review here and on the linked spec change)
lidel
changed the title
This was referenced Dec 8, 2022
Closed
lidel
changed the title
|
We pinged various stakeholders but no concerns were raised here and in libp2p/specs#451 |
This was referenced Dec 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR materializes the discussion in libp2p/specs#451 increasing the provider record's default
TTLorProvideValidityfrom24hto48hbased on RFM17.Motivation
The measurements from RFM17 were quite promising for the steady provider record's liveness gathered in the IPFS live network. Based on the average of 70% of online PR holders and 70% of PR holders being among the 20 closest peers for over +48 hours, we suggest increasing the republish interval for the CIDs and extending the expiration time to help reduce part of the overhead that providing large sets of CIDs implies.
Why 48 hours?
Since the republish interval is intended to be increased up to
22hby a twin PR in ipfs/kubo#9326, setting it to 48h of PR's TTL makes sure that providers have enough margin to publish back the PR before they expire.Modifications
Increase
ProvideValidityfrom24h->48h