feat: increase the max record age to 48h (PUT_VALUE, RFM17) #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lidel
approved these changes
Dec 8, 2022
lidel
changed the title
This was referenced Dec 8, 2022
Closed
lidel
force-pushed
the
increase-max-record-age
branch
from
3188f6a
to
066a664
Compare
|
Unifying this with value from #793 is a good idea, and raising the ceiling of expiration in itself makes things like publishing IPNS records more resilient for use cases there publisher can't be online every day under exact 24h window. 48h make a better real world default ("publish every day, no matter when, and it will be ok"). I rebased this PR to reuse variable from #793, which protects us from diverging defaults in the future. Pinged various stakeholders but no concerns were raised here and in libp2p/specs#451 |
|
Thanks @lidel ! |
This was referenced Dec 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to increase the default value for the IPNS records stored through the PUT_VALUE method from
36hto48hbased on RFM17 as discussed in libp2p/specs#451.Motivation
The measurements from RFM17 were promising and have led to modifying the current republish-interval (ipfs/kubo#9326) and record's expiration time (libp2p/go-libp2p-kad-dht#793). This PR aims to homogenize the expiration of the records to
48h.Modifications
Config.MaxRecordAgefrom36h->48h