Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Refactor dial worker loop into an object and fix bug #315

Merged
merged 4 commits into from Feb 22, 2022
Merged

Refactor dial worker loop into an object and fix bug #315

merged 4 commits into from Feb 22, 2022

Commits on Feb 22, 2022

  1. refactor dialWorkerLoop into an object

    @vyzo
    vyzo committed Feb 22, 2022
    Copy the full SHA
    bedaf66 View commit details
    Browse the repository at this point in the history

  2. remove stale comment

    @vyzo
    vyzo committed Feb 22, 2022
    Copy the full SHA
    835aef6 View commit details
    Browse the repository at this point in the history

  3. RIP active dial tracking 

    It turns out it is not actually necessary if the limiter short-circuits.
Point being is that if the request channel has been closed, there is no active dial
any more, at which point we might as well consider it done.

This fixes the goroutine leak.
    @vyzo
    vyzo committed Feb 22, 2022
    Copy the full SHA
    a5e1b2e View commit details
    Browse the repository at this point in the history

  4. dial worker tests

    @vyzo
    vyzo committed Feb 22, 2022
    Copy the full SHA
    d85a395 View commit details
    Browse the repository at this point in the history