Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup transport suite #34

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix: cleanup transport suite #34

merged 1 commit into from
Jul 23, 2021

Conversation

Stebalien
Copy link
Member

Mostly:

  1. Make it easy to tell where tests fail.
  2. Carefully wait for things to finish (and make sure to clean up).
  3. Don't call Fail from within goroutines.

@Stebalien Stebalien mentioned this pull request Jul 23, 2021
Open
@marten-seemann marten-seemann mentioned this pull request Jul 23, 2021
Closed
@Stebalien Stebalien merged commit 8852a73 into master Jul 23, 2021
@Stebalien Stebalien deleted the fix/transport branch July 23, 2021 17:30
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @marten-seemann