This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
use TLS 1.3 #11
Merged
use TLS 1.3 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, it's using the standard library TLS 1.3 implementation, which is one of the new features of Go 1.12. |
|
I'd like to point out that we're currently not using this code in production yet, so merging this PR shouldn't break anybody's build. I'm currently working on a way to use TLS 1.3 in production (which will also works for Ed25519 keys), but that will definitely won't be production-ready before the release of Go 1.12. |
marten-seemann
force-pushed
the
tls13
branch
2 times, most recently
from
c2dc653
to
ce2c75b
Compare
TLS 1.3 will require Go >= 1.12, so we don't need any fixes that were specific to Go 1.10 any more.
TLS 1.3 support was recently made opt-in in Go 1.12, so we need to explicitly enable it.
marten-seemann
force-pushed
the
tls13
branch
from
ce2c75b
to
1018ec9
Compare
|
This PR should be ready for review & merge now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3.